Merged
Conversation
Member
|
Looks good, the option is documented here. |
mikermcneil
reviewed
Nov 3, 2016
| if (app.config.sockets.subClient) { | ||
| app.config.sockets.adapterOptions.subClient = app.config.sockets.subClient; | ||
| } | ||
| if (app.config.sockets.subEvent) { |
Member
There was a problem hiding this comment.
Looks like we need docs on this one here
cc @sgress454
Member
There was a problem hiding this comment.
@Albi34 would you take a minute to add that to the advanced options table here on the 1.0 branch of sails-docs?
needs type, the default value, and a description, e.g.
Optional. The name of the Redis client event that Socket.io will subscribe to.
(based on https://github.com/socketio/socket.io-redis#adapteropts)
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will allow the inclusion of the subEvent option.
The option is in the current socket.io-redis master branch, it is used because some redis clients are broadcasting the "messageBuffer" event while others the "message" one.