Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MattPereira
changed the title
groninge01
reviewed
Apr 7, 2026
packages/lib/modules/pool/actions/create/steps/details/PoolDetails.tsx
Outdated
Show resolved
Hide resolved
groninge01
reviewed
Apr 7, 2026
packages/lib/modules/pool/actions/create/steps/details/PoolDetails.tsx
Outdated
Show resolved
Hide resolved
groninge01
reviewed
Apr 7, 2026
|
|
||
| const poolSymbol = poolTypePrefix ? `${poolTypePrefix}-${tokenSymbols}` : tokenSymbols | ||
| const suggestedPoolSymbol = | ||
| poolSymbol.length <= MAX_POOL_SYMBOL_LENGTH ? poolSymbol : tokenSymbols |
Collaborator
There was a problem hiding this comment.
what if tokenSymbols.length or poolName.length (on ln 97) is bigger than MAX_POOL_SYMBOL_LENGTH?
Member
Author
There was a problem hiding this comment.
any ideas on how best to handle?
arbitrarily slicing the whole string to fit doesnt make sense imo
slicing each token symbol some to fit also seems messy
my initial thought was to just let user decide 👉 #2311 (comment)
MattPereira
force-pushed
the
fix/pool-creator-feedback
branch
from
7668cd3 to
f4bbd3e
Compare
The tooltip was previously only visible when the donation toggle was disabled (reClamm pools). Now it always displays with contextual help text explaining what donations do and why most pools should not enable them.
Extract name/symbol logic into a getSuggestions helper, add pool type prefixes (surge, reCLAMM), and gracefully omit "Balancer " or the type prefix when they would exceed max length limits.
…SVG cards Replace the PoolSettingsRadioGroup for amplification parameter with the reusable ConfigOptionsGroup component, adding SVG curve illustrations and a third option (10,000). Make ConfigOptionsGroup form-agnostic by accepting a control prop, hardcode the custom option radio, and add forceCustom state to prevent mid-typing snapping when a typed value matches a preset.
MattPereira
force-pushed
the
fix/pool-creator-feedback
branch
from
f4bbd3e to
67a017e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2311
Summary
ConfigOptionsGroupinto a reusable, form-agnostic component by accepting acontrolprop, enabling it to work with both reClamm and pool creation formsPoolSettingsRadioGroupfor amplification parameter withConfigOptionsGroup, adding SVG curve illustrations and three presets (100, 1,000, 10,000) with proper min/max validationConfigOptionsGroupand addedforceCustomstate to prevent the custom input from snapping to a preset while typing (e.g. typing "1001" no longer auto-selects "100")Test plan
1001— confirm the input stays open and doesn't snap to the100preset🤖 Generated with Claude Code