feat: option to boost underlying token during pool creation#2210
Open
MattPereira wants to merge 7 commits intomainfrom
Open
feat: option to boost underlying token during pool creation#2210MattPereira wants to merge 7 commits intomainfrom
MattPereira wants to merge 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
groninge01
reviewed
Mar 10, 2026
Comment on lines
+317
to
+319
| {!token.isBoostingUnderlying | ||
| ? `It’s recommended to use a Boosted version of ${token.data?.symbol} on the ${getChainShortName(network)} network. Balancer v3 is optimized for Boosted tokens. LPs will get additional yield, while still being able to interact with this pool using ${token.data?.symbol}.` | ||
| : `You will wrap your ${getToken(underlyingToken || '', network)?.symbol} into ${token.data?.symbol} during the pool creation process.`} |
Collaborator
There was a problem hiding this comment.
remove the negation and turn it around so it's easier to read?
groninge01
reviewed
Mar 10, 2026
Comment on lines
+164
to
+165
| const resolvedSpender = | ||
| typeof spenderAddress === 'function' ? spenderAddress(tokenAddress) : spenderAddress |
Collaborator
There was a problem hiding this comment.
you created a function for this in useTokenAllowances
MattPereira
force-pushed
the
feat/create-boost-underlying
branch
from
4a55c26 to
e8b7ec2
Compare
MattPereira
force-pushed
the
feat/create-boost-underlying
branch
from
e8b7ec2 to
31819d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1510
Note that the reclamm pool factory is still disabled at the smart contract level
Tokens Step
warning if user selects underlying that has corresponding erc4626 from our whitelist
Fund Step
user inputs wrapped amounts which are used to
previewMinton the erc4626 to get underlying amount requiredTransactions Steps
onSuccessof deposit underlying, update the init amounts to match how much wrapped user received