decrease _next_index when when the request with the minimum log#447
Open
ehds wants to merge 1 commit intobaidu:masterfrom
Open
decrease _next_index when when the request with the minimum log#447ehds wants to merge 1 commit intobaidu:masterfrom
ehds wants to merge 1 commit intobaidu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #421
当且仅当具有最小日志 index 的 send entries 的请求不匹配时，才去缩小 _next_index.
当 pipeline 开启，但是 cache 未开启时，具有较大日志的请求如果先被处理，
response->success = false, 导致 _next_index 被缩小，如果此时 follower 节点加载了快照，那么 _next_index 有可能会小于快照的last_log_index, 从而导致后续的复制都失败。这里限制只有当最小的复制请求的日志不匹配时才有资格缩减 _next_index.