This repository was archived by the owner on Jul 15, 2025. It is now read-only.
Closed
Conversation
haffi96
commented
Nov 5, 2022
Comment on lines
+108
to
+109
| if "authorized" in argument: | ||
| raise exceptions.Unauthorized |
Contributor
Author
There was a problem hiding this comment.
This feels kinda hacky 😕
| """ | ||
| Handle connections to supported k-v storage databases | ||
| """ | ||
| import pickledb |
Contributor
Author
There was a problem hiding this comment.
Im wondering whether to just use redis by default and make it a requirement for this? 🤔 Especially since it will have an api for expiring the key-values out of the box
| lockfile_path: Path = Path("/tmp/.api-reflector.lock") | ||
|
|
||
| # Auth session expiry (minutes) | ||
| session_timeout: int | None = None |
Contributor
Author
There was a problem hiding this comment.
should probably rename this to auth_timeout
Owner
|
i continued this work in #74 based on your ideas here, and co-authored you on it. i'll close this PR in favour of that one. thanks for your work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial draft for #53