This repository was archived by the owner on Jul 15, 2025. It is now read-only.
Add details to response message on error#58
Merged
backwardspy merged 2 commits intobackwardspy:masterfrom Oct 10, 2022
Merged
Conversation
haffi96
commented
Oct 6, 2022
backwardspy
suggested changes
Oct 7, 2022
Owner
backwardspy
left a comment
backwardspy
left a comment
There was a problem hiding this comment.
looks good so far, thanks for the contribution!
i have put my thoughts down in a comment. please let me know what you think.
haffi96
force-pushed
the
Return-reponse-for-template-validation-errors
branch
from
1f98423 to
9a766bd
Compare
backwardspy
suggested changes
Oct 10, 2022
Owner
backwardspy
left a comment
backwardspy
left a comment
There was a problem hiding this comment.
great work, this looks very nice. i have suggested one more change, after which i'll be happy to merge this.
haffi96
force-pushed
the
Return-reponse-for-template-validation-errors
branch
from
9a766bd to
ceedfea
Compare
Owner
|
lgtm! don't worry about the CI failure, it's still using 3.9 so type union syntax isn't supported yet. i'll bump it to 3.10 on this branch and then merge it all. thanks for the contribution! |
backwardspy
force-pushed
the
Return-reponse-for-template-validation-errors
branch
from
ceedfea to
fe9aa03
Compare
backwardspy
approved these changes
Oct 10, 2022
backwardspy
force-pushed
the
Return-reponse-for-template-validation-errors
branch
from
fe9aa03 to
f0f8fd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return more specific responses for templating errors
For errors in rending a response template:
Example 1: Undefined field used
The following content is used on the response template where
typorepresents something not accepted in the rendering"datefield": "{{now() + typo}}"Response:
Example 2: Template syntax error
{"datefield": "{{now()}"}Response:
Questions:
exinto the response. For the cases that I can think to produce, this isn't an issue as it just a one line exception message being passed in. But could we end up with a really long exception message?closes #48