Implemetation of parse geography and geometry datatype by Gopalverma062 · Pull Request #4518 · babelfish-for-postgresql/babelfish_extensions

Gopalverma062 · 2026-02-03T11:48:19Z

Description

Implemented Parse function support for GeoSpatial TSQL data types that was previously unsupported in Babelfish. The Parse function has been added for both geometry and geography data types.

Changes include:

Function Implementation:

Implemented geometry::Parse() and geography::Parse() functions by utilizing PostGIS parsing capabilities with necessary adjustments to ensure TSQL compatibility.

Parser Updates:

Added Parse function definitions to the TSQL parser to recognize these new static methods.
Ensured proper syntax handling for Parse function, including NVARCHAR parameter types and return values.

Test Cases:

Created comprehensive test cases for Parse function, covering various scenarios including basic parsing, empty geometries, NULL handling, whitespace tolerance, case insensitivity, and error conditions.

Error Handling:

Implemented appropriate error handling for invalid geometry strings and malformed inputs.

Extending existing functionalities:

Added support for parsing empty instances in both geometry and geography datatypes
Enhanced CAST operations compatibility with Parse results
Added hierarchyid::Parse() support for completeness

Testing:

All new Parse functions pass the added test cases.
Existing functionality remains unaffected.

Examples:

For `geometry::Parse`

DECLARE @geomText NVARCHAR(MAX);
SET @geomText = 'POINT(1.0 2.0)';
SELECT geometry::Parse(@geomText).STAsText() AS ParsedGeometry;
GO

Output:

ParsedGeometry
--------------
POINT(1 2)

For `geography::Parse`

DECLARE @geogText NVARCHAR(MAX);
SET @geogText = 'LINESTRING(0 0, 1 1, 2 2)';
SELECT geography::Parse(@geogText).STAsText() AS ParsedGeography;
GO

Output:

ParsedGeography
---------------
LINESTRING(0 0,1 1,2 2)

For Empty Geometry Parsing

DECLARE @emptyPoint NVARCHAR(MAX);
SET @emptyPoint = 'POINT EMPTY';
SELECT geometry::Parse(@emptyPoint).STAsText() AS ParsedGeometry;
GO

Output:

ParsedGeometry
--------------
POINT EMPTY

Issues Resolved

Task: 6339

Signed-off by: Gopalgv gopalgv@amazon.com

Authored by: Gopalgv gopalgv@amazon.com

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

coveralls · 2026-02-03T12:16:41Z

Pull Request Test Coverage Report for Build 22102330700

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
944 unchanged lines in 8 files lost coverage.
Overall coverage increased (+0.003%) to 76.996%

Files with Coverage Reduction	New Missed Lines	%
contrib/babelfishpg_tsql/src/hooks.c	1	85.82%
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c	2	76.23%
contrib/babelfishpg_tds/src/backend/tds/tdsresponse.c	2	80.9%
contrib/babelfishpg_tsql/src/session.c	4	96.62%
contrib/babelfishpg_tds/src/backend/tds/tdslogin.c	31	77.42%
contrib/babelfishpg_tsql/src/collation.c	32	80.88%
contrib/babelfishpg_tsql/src/pl_handler.c	215	90.82%
contrib/babelfishpg_tsql/src/pl_exec.c	657	44.52%

Totals
Change from base Build 21625550326:	0.003%
Covered Lines:	52722
Relevant Lines:	68474

💛 - Coveralls

rishabhtanwar29 · 2026-02-04T05:29:47Z

contrib/babelfishpg_common/sql/upgrades/spatial_types--5.5.0--5.6.0.sql

+    RETURNS sys.GEOMETRY
+    AS $$
+    BEGIN
+	    IF UPPER(geometry_tagged_text::text COLLATE "default") = 'NULL' THEN


Why do we need to cast it to text first? Can't we directly compare the nvarchar?

Mohitraj-g · 2026-02-11T12:47:53Z

contrib/babelfishpg_common/sql/upgrades/spatial_types--5.5.0--5.6.0.sql

+    RETURNS sys.GEOMETRY
+    AS $$
+    BEGIN
+	     IF UPPER(geometry_tagged_text COLLATE "default") = 'NULL' THEN


Parse function should be implemented similar to stgeomfromtext. Please verify.

yes i follow the same structure in Parse as a STGeomfromtext

Mohitraj-g · 2026-02-11T12:49:47Z

test/JDBC/expected/Test-spatial-functions-3-vu-prepare.out

+INSERT INTO TestGeospatialParse_GeometryTable3 (ID, GeomColumn) VALUES (1, geometry::Point(3.0, 4.0, 4326));
+~~ROW COUNT: 1~~
+
+INSERT INTO TestGeospatialParse_GeometryTable3 (ID, GeomColumn) VALUES (2, geometry::STGeomFromText('LINESTRING(0 0, 1 1, 2 2)', 4326));


These tests should be like geometry::Parse('LINESTRING(0 0, 1 1, 2 2)', 4326)); . Need to update all the tests.

done i have fixed it

Mohitraj-g · 2026-02-11T12:50:46Z

test/JDBC/expected/Test-spatial-functions-3-vu-prepare.out

+INSERT INTO TestGeospatialParse_GeographyTable3 (ID, GeogColumn) VALUES (1, geography::Point(3.0, 4.0, 4326));
+~~ROW COUNT: 1~~
+
+INSERT INTO TestGeospatialParse_GeographyTable3 (ID, GeogColumn) VALUES (2, geography::STGeomFromText('LINESTRING(0 0, 1 1, 2 2)', 4326));


We need more coverage like: Linestring with XY, XYM, XYZ, XYZM points

done i have addded the more table and testcases which covering XY, XYM, XYZ, XYZM

Mohitraj-g · 2026-02-11T12:51:22Z

test/JDBC/input/datatypes/Test-spatial-functions-2-vu-prepare.txt

 CREATE VIEW TestGeospatialMethods_empty_ValFromGeomTemp AS SELECT location.STIsEmpty() FROM TestGeospatialMethods_SPATIALPOINTGEOM_dttemp ORDER BY location.STX;

-CREATE VIEW TestGeospatialMethods_empty_TextFromGeomTemp AS SELECT  location.STIsEmpty() AS Dimension FROM TestGeospatialMethods_SPATIALPOINTGEOG_dttemp ORDER BY location.Lat;
+CREATE VIEW TestGeospatialMethods_empty_TextFromGeomTemp AS SELECT  location.STIsEmpty() AS Dimension FROM TestGeospatialMethods_SPATIALPOINTGEOG_dttemp ORDER BY location.Lat;


Please remove changes in Test-spatial-functions-2 files.

Mohitraj-g · 2026-02-11T12:52:25Z

test/JDBC/input/datatypes/Test-spatial-functions-3-vu-verify.sql

+
+DECLARE @geogText NVARCHAR(MAX);
+SET @geogText = 'POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))';
+SELECT geography::Parse(@geogText).STAsText() AS ParsedGeography;


We should also test Parse function alone without STAsText

i have added the testcase that test parse alone without STAsText

Mohitraj-g · 2026-02-11T12:53:36Z

test/python/expected/upgrade_validation/expected_dependency.out

 Function sys.geography(sys.bpchar)
 Function sys.geography(sys.geography,integer,boolean)
 Function sys.geography(text,integer,boolean)
+Function sys.geography__parse(sys.nvarchar)


We can remove this by creating a dependency for Parse function eg. CREATE VIEW

ahmed-shameem · 2026-02-16T15:57:45Z

contrib/babelfishpg_common/sql/geography.sql

+    RETURNS sys.GEOGRAPHY
+    AS $$
+    BEGIN
+	    IF UPPER(geography_tagged_text COLLATE "default") = 'NULL' THEN


COLLATE "default" should not be used here. use DATABASE_DEFAULT instead. "default" is a postgres collation, not babelfish collation

yes i have fixed it

ahmed-shameem · 2026-02-16T15:58:23Z

contrib/babelfishpg_common/sql/geography.sql

+            RAISE EXCEPTION 'parse error - invalid geometry';
+        END IF;
+
+        RETURN sys.geogfromtext_helper(geography_tagged_text::text, 4326);


Why do we need to cast geography_tagged_text to text again? sys.geogfromtext_helper should be doing that implicitly

i have fixed it

ahmed-shameem · 2026-02-16T15:58:37Z

contrib/babelfishpg_common/sql/geography.sql

+            RETURN NULL;
+        END IF;
+		 -- Reject Z/ZM dimension qualifier
+        IF geography_tagged_text COLLATE "default" ~* '\s+ZM?\s*\(' THEN


Same comment as above

ahmed-shameem · 2026-02-16T15:58:49Z

contrib/babelfishpg_common/sql/geometry.sql

 	$$ LANGUAGE plpgsql IMMUTABLE STRICT PARALLEL SAFE;

+--Parse
+CREATE OR REPLACE FUNCTION sys.Geometry__Parse(geometry_tagged_text sys.NVARCHAR)


Same comment as above

ahmed-shameem · 2026-02-16T15:59:04Z

contrib/babelfishpg_tsql/antlr/TSqlParser.g4


 hierarchyid_static_method
    : GETROOT
-    | PARSE


Why did we remove from here?

PARSE was incorrectly categorized under hierarchyid_static_method. After discussing with Rohit i ,removed it from here

ahmed-shameem · 2026-02-16T16:00:23Z

test/JDBC/input/datatypes/Test-spatial-functions-3-vu-verify.sql

@@ -0,0 +1,382 @@
+--Parse


Please add comments stating what are we testing for ease of reviewing. Thanks!

…_PARSE

…-postgresql#4518) Implemented Parse function support for GeoSpatial TSQL data types that was previously unsupported in Babelfish. The Parse function has been added for both geometry and geography data types. Changes include: Implemented geometry::Parse() and geography::Parse() functions by utilizing PostGIS parsing capabilities with necessary adjustments to ensure TSQL compatibility. Added Parse function definitions to the TSQL parser to recognize these new static methods. Ensured proper syntax handling for Parse function, including NVARCHAR parameter types and return values. Examples: DECLARE @geomText NVARCHAR(MAX); SET @geomText = 'POINT(1.0 2.0)'; SELECT geometry::Parse(@geomText).STAsText() AS ParsedGeometry; GO ParsedGeometry -------------- POINT(1 2) DECLARE @geogText NVARCHAR(MAX); SET @geogText = 'LINESTRING(0 0, 1 1, 2 2)'; SELECT geography::Parse(@geogText).STAsText() AS ParsedGeography; GO ParsedGeography --------------- LINESTRING(0 0,1 1,2 2) Task: BABEL-6310 Signed-off by: Gopalgv gopalgv@amazon.com

Implemented Parse function support for GeoSpatial TSQL data types that was previously unsupported in Babelfish. The Parse function has been added for both geometry and geography data types. Changes include: Implemented geometry::Parse() and geography::Parse() functions by utilizing PostGIS parsing capabilities with necessary adjustments to ensure TSQL compatibility. Added Parse function definitions to the TSQL parser to recognize these new static methods. Ensured proper syntax handling for Parse function, including NVARCHAR parameter types and return values. Examples: DECLARE @geomText NVARCHAR(MAX); SET @geomText = 'POINT(1.0 2.0)'; SELECT geometry::Parse(@geomText).STAsText() AS ParsedGeometry; GO ParsedGeometry -------------- POINT(1 2) DECLARE @geogText NVARCHAR(MAX); SET @geogText = 'LINESTRING(0 0, 1 1, 2 2)'; SELECT geography::Parse(@geogText).STAsText() AS ParsedGeography; GO ParsedGeography --------------- LINESTRING(0 0,1 1,2 2) Task: BABEL-6310 Signed-off by: Gopalgv gopalgv@amazon.com

Implemetation of parse geography and geometry datatype

0fc3af8

Gopal Verma added 3 commits February 3, 2026 12:38

add Dependency in expected_dependency.out file

d23a5cb

FIX in the dependency file

3bfe439

Update in Spatial_types--5.5.0-5.6.0 file

b3bf3e5

rishabhtanwar29 reviewed Feb 4, 2026

View reviewed changes

Gopal Verma added 5 commits February 4, 2026 19:22

Pr comment addressed

f2a66ac

spatial_type file code fix

0d70d2e

change in schedule file

f327b39

Fix in output file

ec772ef

Add Test-spatial-functions-3 and update spatial function

4e2f61b

rishabhtanwar29 previously approved these changes Feb 11, 2026

View reviewed changes

Mohitraj-g reviewed Feb 11, 2026

View reviewed changes

Add test coverage for XYZ, XYM, and XYZM coordinates

e58116a

Gopalverma062 dismissed rishabhtanwar29’s stale review via e58116a February 13, 2026 08:37

update spatial_types file

4efb617

ahmed-shameem suggested changes Feb 16, 2026

View reviewed changes

adding comments

4872627

rishabhtanwar29 previously approved these changes Feb 18, 2026

View reviewed changes

adding sys before the DATABASE_DEAFULT

c47afb0

Gopalverma062 dismissed rishabhtanwar29’s stale review via c47afb0 February 23, 2026 09:21

Gopal Verma added 5 commits February 24, 2026 06:47

Merge remote-tracking branch 'upstream/BABEL_5_X_DEV' into BABEL_6310…

512a1bc

…_PARSE

merge conflict resolve

f7b2343

solving merge_conflict

ace75e4

adding ignore for testcases file in the Singledb_JDBC_schedule

056fad9

EMPTY_COMMIT

3f640cc

rishabhtanwar29 approved these changes Feb 27, 2026

View reviewed changes

Mohitraj-g approved these changes Feb 27, 2026

View reviewed changes

ahmed-shameem approved these changes Feb 28, 2026

View reviewed changes

shardgupta merged commit e04abbc into babelfish-for-postgresql:BABEL_5_X_DEV Mar 1, 2026
68 of 70 checks passed

Conversation

Gopalverma062 commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes include:

Function Implementation:

Parser Updates:

Test Cases:

Error Handling:

Extending existing functionalities:

Testing:

Examples:

For geometry::Parse

For geography::Parse

For Empty Geometry Parsing

Issues Resolved

Check List

Uh oh!

coveralls commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 22102330700

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gopalverma062 Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Gopalverma062 commented Feb 3, 2026 •

edited

Loading

For `geometry::Parse`

For `geography::Parse`

coveralls commented Feb 3, 2026 •

edited

Loading

Gopalverma062 Feb 18, 2026 •

edited

Loading