Supported PostGIS Function: STNumPoints for Geospatial datatypes by Gopalverma062 · Pull Request #4510 · babelfish-for-postgresql/babelfish_extensions

Gopalverma062 · 2026-02-01T17:34:46Z

Implement STNumPoints GeoSpatial SQL Function

Implemented the STNumPoints GeoSpatial TSQL function that was previously unsupported in Babelfish.

What's Changed

Function Implementation

Added sys.STNumPoints(geog sys.GEOGRAPHY) function in geography.sql
Delegates to sys.STNumPoints_geography_helper() for valid, non-empty instances
Function is marked as IMMUTABLE STRICT PARALLEL SAFE for optimal performance

Error Handling

Returns exception for invalid geography instances
Returns 0 for empty geography instances
Returns actual point count for valid instances

Function Behavior

Input	Output
Valid geography instance	Integer count of points
Empty geography instance	0
Invalid geography instance	Exception

Examples

Point

DECLARE @point geography;
SET @point = geography::STPointFromText('POINT(-122.34900 47.65100)', 4326);
SELECT @point.STNumPoints() AS NumPoints;
-- Output: 1

LineString

DECLARE @line geography;
SET @line = geography::STGeomFromText('LINESTRING(-122.360 47.656, -122.343 47.656, -122.310 47.690)', 4326);
SELECT @line.STNumPoints() AS NumPoints;
-- Output: 3

Polygon

DECLARE @polygon geography;
SET @polygon = geography::STGeomFromText('POLYGON((-122.358 47.653, -122.348 47.649, -122.348 47.658, -122.358 47.658, -122.358 47.653))', 4326);
SELECT @polygon.STNumPoints() AS NumPoints;
-- Output: 5

Empty Instance

DECLARE @empty geography;
SET @empty = geography::STGeomFromText('POINT EMPTY', 4326);
SELECT @empty.STNumPoints() AS NumPoints;
-- Output: 0

Issues Resolved

Task: BABEL-6329

Signed-off by: Gopal verma [email protected]

Authored by: Gopal verma [email protected]

Test Coverage

Use case based
Boundary conditions
Arbitrary inputs
Negative test cases

Checklist

Commits are signed per the DCO using --signoff
Contribution is under Apache 2.0 and PostgreSQL licenses

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

coveralls · 2026-02-02T09:52:41Z

Pull Request Test Coverage Report for Build 22109069228

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1081 unchanged lines in 9 files lost coverage.
Overall coverage decreased (-0.001%) to 76.99%

Files with Coverage Reduction	New Missed Lines	%
contrib/babelfishpg_tsql/src/hooks.c	1	85.82%
contrib/babelfishpg_tds/src/backend/tds/tdsresponse.c	2	80.9%
contrib/babelfishpg_tsql/src/session.c	4	96.62%
contrib/babelfishpg_tds/src/backend/tds/tdslogin.c	31	77.42%
contrib/babelfishpg_tsql/src/collation.c	32	80.88%
contrib/babelfishpg_tds/src/include/tds_request.h	36	76.22%
contrib/babelfishpg_tds/src/backend/tds/tdstypeio.c	103	87.44%
contrib/babelfishpg_tsql/src/pl_handler.c	215	90.82%
contrib/babelfishpg_tsql/src/pl_exec.c	657	44.52%

Totals
Change from base Build 21506975134:	-0.001%
Covered Lines:	52718
Relevant Lines:	68474

💛 - Coveralls

rishabhtanwar29 · 2026-02-02T10:53:24Z

contrib/babelfishpg_common/sql/upgrades/spatial_types--5.5.0--5.6.0.sql

+
+        geom_type := ST_GeometryType(geom);
+
+        IF geom_type = 'ST_Point' THEN


Does this mean Postgis is not able to handle empty geometry and Point?

done, i have fixed it

rishabhtanwar29 · 2026-02-02T10:58:07Z

contrib/babelfishpg_common/sql/upgrades/spatial_types--5.5.0--5.6.0.sql

+
+        IF geom_type = 'ST_Point' THEN
+            RETURN 1;
+        ELSIF geom_type IN ('ST_LineString', 'ST_Polygon', 'ST_MultiLineString', 'ST_MultiPolygon') THEN


Is this condition because postgis only supports these geometries or is it that we support these for now? If later than IMO we should instead directly call STNumPoints_helper for all geometry types as otherwise we would need to update this function each time we support a new geometry type.

done i have fixed it

rishabhtanwar29 · 2026-02-10T04:16:04Z

test/JDBC/input/datatypes/Test-spatial-functions-2-vu-verify.sql

IMO, we should create a new set of test files now, something like Test-spatial-functions-3-vu-*

done i have created

…files

Mohitraj-g · 2026-02-11T13:12:30Z

contrib/babelfishpg_common/sql/upgrades/spatial_types--5.5.0--5.6.0.sql

+	AS $$
+	BEGIN
+		IF sys.STIsValid(geog) = 0 THEN
+			RAISE EXCEPTION 'The geography instance is not valid. Use MakeValid() to convert to valid geography.';


The error message is not same as in geography.sql. Please check!

done i have fixed it

Mohitraj-g · 2026-02-11T13:15:04Z

test/python/expected/upgrade_validation/expected_dependency.out

 Function sys.stintersects_helper(sys.geometry,sys.geometry)
 Function sys.stisclosed_helper(sys.geography)
 Function sys.stisclosed_helper(sys.geometry)
+Function sys.stnumpoints_helper(sys.geography)


We can remove this by creating a dependency for STNumPoints function eg. CREATE VIEW. Please verify this for all functions.

ahmed-shameem · 2026-02-16T15:39:52Z

contrib/babelfishpg_common/sql/geography.sql

+	BEGIN
+		IF sys.STIsValid(geog) = 0 THEN
+			RAISE EXCEPTION 'The geography instance is not valid';
+		ELSE


Don't we need to check whether geography is empty or not?

actually it is handled by the c functions

ahmed-shameem · 2026-02-16T15:40:30Z

contrib/babelfishpg_common/sql/geometry.sql

+        IF STIsValid(geom) = 0 THEN
+            RAISE EXCEPTION 'The geometry instance is not valid';
+        ELSE
+            RETURN sys.STNumPoints_helper(geom);


Don't we need to check whether geometry is empty or not?

actually it is handled by the c functions

ahmed-shameem · 2026-02-16T15:45:41Z

test/JDBC/input/datatypes/Test-spatial-functions-3-vu-prepare.txt

@@ -0,0 +1,42 @@
+CREATE DATABASE TestSTNumPoints_DB;


Why is the test file .txt and not .sql?

This allows us to add JDBC test directives (like prepst#!# for prepared statement testing)

ahmed-shameem · 2026-02-16T15:46:25Z

test/JDBC/input/datatypes/Test-spatial-functions-3-vu-prepare.txt

+
+USE TestSTNumPoints_DB;
+
+USE MASTER


What's the point of creating TestSTNumPoints_DB? We are simply creating the db and not using it. All the objects are created inside master db. So what's the point?

fixed The database now contains the test tables and corresponding tests have been added in the verify file.

ahmed-shameem · 2026-02-16T15:47:48Z

test/JDBC/input/datatypes/Test-spatial-functions-3-vu-verify.sql

@@ -0,0 +1,161 @@
+--STNumPoints()


Please add some comments on the test cases as to what we are testing. For eg: invalid input, null input, empty input, negative tests etc.

Done Added comments

ahmed-shameem · 2026-02-16T15:48:05Z

test/JDBC/input/datatypes/Test-spatial-functions-3-vu-cleanup.txt

@@ -0,0 +1,13 @@
+USE TestSTNumPoints_DB 
+
+USE MASTER 


Again, what's the point of creating TestSTNumPoints_DB?

fixed The database now contains the test tables and corresponding tests have been added in the verify file.

jsudrik

Approved.

…elfish-for-postgresql#4510) Implemented the STNumPoints GeoSpatial TSQL function that was previously unsupported in Babelfish. BABEL-6329 --------- Co-authored-by: Gopal Verma <[email protected]>

@point

…) (#4676) Implemented the STNumPoints GeoSpatial TSQL function that was previously unsupported in Babelfish. ## What's Changed ### Function Implementation - Added `sys.STNumPoints(geog sys.GEOGRAPHY)` function in `geography.sql` - Delegates to `sys.STNumPoints_geography_helper()` for valid, non-empty instances - Function is marked as `IMMUTABLE STRICT PARALLEL SAFE` for optimal performance ### Error Handling - Returns exception for invalid geography instances - Returns 0 for empty geography instances - Returns actual point count for valid instances --- ## Function Behavior | Input | Output | |-------|--------| | Valid geography instance | Integer count of points | | Empty geography instance | 0 | | Invalid geography instance | Exception | --- ## Examples **Point** DECLARE @point geography; SET @point = geography::STPointFromText('POINT(-122.34900 47.65100)', 4326); SELECT @point.STNumPoints() AS NumPoints; -- Output: 1 **LineString** DECLARE @line geography; SET @line = geography::STGeomFromText('LINESTRING(-122.360 47.656, -122.343 47.656, -122.310 47.690)', 4326); SELECT @line.STNumPoints() AS NumPoints; -- Output: 3 **Polygon** DECLARE @polygon geography; SET @polygon = geography::STGeomFromText('POLYGON((-122.358 47.653, -122.348 47.649, -122.348 47.658, -122.358 47.658, -122.358 47.653))', 4326); SELECT @polygon.STNumPoints() AS NumPoints; -- Output: 5 **Empty Instance** DECLARE @empty geography; SET @empty = geography::STGeomFromText('POINT EMPTY', 4326); SELECT @empty.STNumPoints() AS NumPoints; -- Output: 0 Task: BABEL-6329 Signed-off by: Gopal verma <[email protected]>

Gopal Verma added 4 commits February 1, 2026 16:59

BABEL-6310: Add STNumPoints support for geometry and geography types

cce0cb2

Add expected_dependency files

05575eb

Fix in STNumPoints testcases

b3d80e1

Update Numeric_Decimal_tests expected output for STNumPoints support

abe951b

rishabhtanwar29 reviewed Feb 2, 2026

View reviewed changes

Gopal Verma added 3 commits February 3, 2026 08:42

code fixes in Pr

fe1c5e9

Added before version files

b920386

adding of parallel_query/numerical_decimal_tests.out

51e7b6c

rishabhtanwar29 reviewed Feb 10, 2026

View reviewed changes

Remove deprecated Test-spatial-functions-2-before-17_9-or-16_13 test …

5f2696c

…files

Mohitraj-g reviewed Feb 11, 2026

View reviewed changes

Gopal Verma added 2 commits February 11, 2026 19:59

addresing the comments

52de55b

adding dependency file

6919fab

ahmed-shameem suggested changes Feb 16, 2026

View reviewed changes

Gopal Verma added 2 commits February 17, 2026 15:44

adding comments in testcases

8c60d16

fix order_by issue

f7ee44e

rishabhtanwar29 previously approved these changes Feb 18, 2026

View reviewed changes

ahmed-shameem approved these changes Feb 19, 2026

View reviewed changes

Merge upstream/BABEL_5_X_DEV

c7a0702

Gopalverma062 dismissed rishabhtanwar29’s stale review via c7a0702 March 2, 2026 11:09

resolving merge conflict and precison difference testfailure

6df506d

rishabhtanwar29 previously approved these changes Mar 2, 2026

View reviewed changes

fixing the test_files

294d73d

Gopalverma062 dismissed rishabhtanwar29’s stale review via 294d73d March 2, 2026 15:21

Gopal Verma added 3 commits March 2, 2026 15:52

chnages the testcases

255b941

EMPTY

511e761

trigger CI

0484446

Mohitraj-g approved these changes Mar 2, 2026

View reviewed changes

rishabhtanwar29 approved these changes Mar 3, 2026

View reviewed changes

jsudrik approved these changes Mar 3, 2026

View reviewed changes

jsudrik merged commit 4c4798e into babelfish-for-postgresql:BABEL_5_X_DEV Mar 3, 2026
47 checks passed


		geom_type := ST_GeometryType(geom);

		IF geom_type = 'ST_Point' THEN


		USE TestSTNumPoints_DB;

		USE MASTER

Conversation

Gopalverma062 commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implement STNumPoints GeoSpatial SQL Function

What's Changed

Function Implementation

Error Handling

Function Behavior

Examples

Issues Resolved

Test Coverage

Checklist

Uh oh!

coveralls commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 22109069228

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahmed-shameem Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsudrik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Gopalverma062 commented Feb 1, 2026 •

edited

Loading

coveralls commented Feb 2, 2026 •

edited

Loading

ahmed-shameem Feb 16, 2026 •

edited

Loading