Implement STGeometryType for geometry and geography types by Gopalverma062 · Pull Request #4509 · babelfish-for-postgresql/babelfish_extensions

Gopalverma062 · 2026-02-01T10:29:26Z

Description

Implement STGeometryType for Geometry and Geography Types**

Implemented the STGeometryType() method for both sys.GEOMETRY and sys.GEOGRAPHY types, extending the existing geospatial functionality in Babelfish. This function returns the geometry type name (Point, LineString, Polygon, etc.) with full TSQL compatibility.

Changes Made

Function Implementations:

STGeometryType for sys.GEOMETRY - Returns geometry type name with proper validation
STGeometryType for sys.GEOGRAPHY - Returns geography type name with same behavior
Utilizes PostGIS functions with necessary adjustments for TSQL compatibility
Strips 'ST_' prefix from PostGIS type names to match TSQL Server format

Key Features:

Input Validation: Validates geometry/geography instances using STIsValid() before processing
Error Handling: Throws appropriate exceptions for invalid instances
SQL Server Compatibility: Returns sys.NVARCHAR type and matches TSQL naming conventions
NULL Handling: Proper handling of NULL inputs with STRICT function attribute
Thread Safety: Implemented with PARALLEL SAFE attribute

Examples

For STGeometryType (Geometry):

DECLARE @geom geometry;
SET @geom = geometry::STGeomFromText('POINT(1 2)', 4326);
SELECT @geom.STGeometryType();

Output: Point

For STGeometryType (Geography):

DECLARE @geog geography;
SET @geog = geography::STGeomFromText('LINESTRING(-122.36 47.65, -122.34 47.66)', 4326);
SELECT @geog.STGeometryType();

Output: LineString

Table Operations:

SELECT ID, GeomColumn.STGeometryType() AS GeometryType 
FROM TestTable 
WHERE GeomColumn.STGeometryType() = 'Point';

Files Modified

geometry.sql - Added STGeometryType for geometry type
geography.sql - Added STGeometryType for geography type
spatial_types--5.5.0--5.6.0.sql - Upgrade script
Test files with comprehensive coverage

Issues Resolved

BABEL-6330 - Implement STGeometryType for Geometry and Geography Types

Signed-off by: gopalgv gopalgv@amazon.com

Authored by: gopalgv gopalgv@amazon.com

Checklist

Commits are signed per the DCO using --signoff
Contribution is under Apache 2.0 and PostgreSQL licenses

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

coveralls · 2026-02-01T10:57:30Z

Pull Request Test Coverage Report for Build 22112542606

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1081 unchanged lines in 9 files lost coverage.
Overall coverage decreased (-0.001%) to 76.99%

Files with Coverage Reduction	New Missed Lines	%
contrib/babelfishpg_tsql/src/hooks.c	1	85.82%
contrib/babelfishpg_tds/src/backend/tds/tdsresponse.c	2	80.9%
contrib/babelfishpg_tsql/src/session.c	4	96.62%
contrib/babelfishpg_tds/src/backend/tds/tdslogin.c	31	77.42%
contrib/babelfishpg_tsql/src/collation.c	32	80.88%
contrib/babelfishpg_tds/src/include/tds_request.h	36	76.22%
contrib/babelfishpg_tds/src/backend/tds/tdstypeio.c	103	87.44%
contrib/babelfishpg_tsql/src/pl_handler.c	215	90.82%
contrib/babelfishpg_tsql/src/pl_exec.c	657	44.52%

Totals
Change from base Build 21506975134:	-0.001%
Covered Lines:	52718
Relevant Lines:	68474

💛 - Coveralls

rishabhtanwar29 · 2026-02-02T10:43:12Z

+
+--Geometry
+CREATE OR REPLACE FUNCTION sys.STGeometryType(geom sys.GEOMETRY)
+	RETURNS sys.NVARCHAR


Documentation says that it should be nvarchar(4000) so we should stick to that.

done, i have fixed it

rishabhtanwar29 · 2026-02-02T10:45:57Z

+			RETURN substr(geom_type, 4);
+		END IF;
+
+		RETURN geom_type;


I think we should raise exception in case geom_type is not in 'ST_%' format.

done, i have raised the exception

rishabhtanwar29 · 2026-02-02T10:47:12Z

+--Geography
+
+CREATE OR REPLACE FUNCTION sys.STGeometryType(geog sys.GEOGRAPHY)
+	RETURNS sys.NVARCHAR


Same as above, it should be nvarchar(4000)

done ,i have fixed it

Mohitraj-g · 2026-02-11T13:03:40Z

+			RETURN substr(geom_type, 4);
+		END IF;
+
+		RAISE EXCEPTION 'Unexpected geometry type format: %. Expected ST_* prefix.', geom_type;


Why do you need this ? it can be handled by ST_GeometryType internally right ?

Rishabh asked me to raise the exception for this

ahmed-shameem · 2026-02-16T15:51:56Z

+        END IF;
+		geom_type := sys.ST_GeometryType(geog);
+
+		IF geom_type LIKE 'ST_%' THEN


'' is a wildcard in LIKE operator. Using 'ST%' means any string of the form 'ST<any_single_character>' will be valid here. I do not think we want that. Please use something like:

geom_type LIKE 'ST\_%' ESCAPE '\'

i have fixed this

ahmed-shameem · 2026-02-16T15:52:19Z

+        IF STIsValid(geog) = 0 THEN
+            RAISE EXCEPTION 'This operation cannot be completed because the instance is not valid';
+        END IF;
+		geom_type := sys.ST_GeometryType(geog);


Don't we need to check whether it is empty or not?

actually it is handled by the c functions

ahmed-shameem · 2026-02-16T15:52:55Z

 	$$ LANGUAGE plpgsql IMMUTABLE STRICT PARALLEL SAFE;
+
+--STGeomType
+CREATE OR REPLACE FUNCTION sys.STGeometryType(geom sys.GEOMETRY)


Same comments as previous comments

actually it is handled by the c functions

ahmed-shameem · 2026-02-16T15:53:22Z

 	$$ LANGUAGE plpgsql IMMUTABLE STRICT PARALLEL SAFE;

+--STGeomType 
+CREATE OR REPLACE FUNCTION sys.STGeometryType(geog sys.GEOGRAPHY)


Why the name of the function suggests geometry whereas the input is of type geography?

The function is named STGeometryType to match T-SQL documentation

ahmed-shameem · 2026-02-16T15:54:15Z

@@ -0,0 +1,13 @@
+USE TestGeospatialMethods3_DB 


Why the test file is .txt and not .sql?

In the future, we may add special test directives like prepst#!# thats why it is the .txt not .sql

ahmed-shameem · 2026-02-16T15:54:27Z

@@ -0,0 +1,13 @@
+USE TestGeospatialMethods3_DB 
+
+USE MASTER 


What's the point of creating TestGeospatialMethods3_DB db?

Fixed The database now contains the test tables and corresponding tests have been added in the verify file.

ahmed-shameem · 2026-02-16T15:54:39Z

@@ -0,0 +1,32 @@
+CREATE DATABASE TestGeospatialMethods3_DB;


Same comment as above^

i have added tables and corrosponding testcases in verify.sql file

ahmed-shameem · 2026-02-16T15:55:20Z

@@ -0,0 +1,231 @@
+SELECT geometry::STGeomFromText('POINT(1 2)', 4326).STGeometryType();


Please add comments stating what are we testing: null input, empty input, negative test case, invalid input etc

yes i have mark the comments in test files

…for-postgresql#4509) Implemented the STGeometryType() method for both sys.GEOMETRY and sys.GEOGRAPHY types, extending the existing geospatial functionality in Babelfish. This function returns the geometry type name (Point, LineString, Polygon, etc.) with full TSQL compatibility. Changes Made Function Implementations: STGeometryType for sys.GEOMETRY - Returns geometry type name with proper validation STGeometryType for sys.GEOGRAPHY - Returns geography type name with same behavior Utilizes PostGIS functions with necessary adjustments for TSQL compatibility Strips 'ST_' prefix from PostGIS type names to match TSQL Server format Task: BABEL-6310 Signed-off by: gopalgv gopalgv@amazon.com

BABEL_6310: Implement STGeometryType for geometry and geography types

9151503

rishabhtanwar29 changed the title ~~BABEL_6310: Implement STGeometryType for geometry and geography types~~ Implement STGeometryType for geometry and geography types Feb 2, 2026

rishabhtanwar29 reviewed Feb 2, 2026

View reviewed changes

Gopal Verma added 3 commits February 3, 2026 09:22

update return

ec0f6c3

Adding before file

3fa9a5a

BABEL-6310: Add Test-spatial-functions-3 tests

4fb091e

rishabhtanwar29 previously approved these changes Feb 11, 2026

View reviewed changes

Mohitraj-g reviewed Feb 11, 2026

View reviewed changes

ahmed-shameem suggested changes Feb 16, 2026

View reviewed changes

adding comments in testcases files

3ee7c1f

Gopalverma062 dismissed rishabhtanwar29’s stale review via 3ee7c1f February 17, 2026 17:26

fixes

c475df9

rishabhtanwar29 approved these changes Feb 18, 2026

View reviewed changes

ahmed-shameem approved these changes Feb 19, 2026

View reviewed changes

Mohitraj-g approved these changes Feb 23, 2026

View reviewed changes

shardgupta merged commit b5bc2fa into babelfish-for-postgresql:BABEL_5_X_DEV Feb 23, 2026
47 of 48 checks passed

		@@ -0,0 +1,231 @@
		SELECT geometry::STGeomFromText('POINT(1 2)', 4326).STGeometryType();

Conversation

Gopalverma062 commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes Made

Examples

Files Modified

Issues Resolved

Checklist

Uh oh!

coveralls commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 22112542606

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Gopalverma062 commented Feb 1, 2026 •

edited

Loading

coveralls commented Feb 1, 2026 •

edited

Loading