Add STLength support for geography and geometry types by Gopalverma062 · Pull Request #4468 · babelfish-for-postgresql/babelfish_extensions

Gopalverma062 · 2026-01-21T05:39:36Z

Description

Implemented STLength() GeoSpatial TSQL function that was previously unsupported in Babelfish.

Changes

Function Implementation

Implemented STLength() function by utilizing PostGIS functions where appropriate
Made necessary adjustments to ensure TSQL compatibility

Parser Updates

Added function definitions to the TSQL parser to recognize the new function
Ensured proper syntax handling including parameter types and return values

Test Cases

Created comprehensive test cases covering various scenarios
Added edge case testing for validation

Error Handling

Implemented appropriate error handling for invalid inputs and edge cases

Extended Existing Functionalities

Added support for empty instances in geography datatypes
Fixed binary string handling for dump and restore tests

Testing

All new functions pass the added test cases
Existing functionality remains unaffected

Signed-off-by: Gopal Verma <[email protected]>

contrib/babelfishpg_common/sql/geography.sql

contrib/babelfishpg_common/sql/geometry.sql

contrib/babelfishpg_common/sql/geography.sql

contrib/babelfishpg_tsql/antlr/TSqlLexer.g4

contrib/babelfishpg_tsql/antlr/TSqlParser.g4

Mohitraj-g · 2026-01-21T11:05:46Z

test/JDBC/input/datatypes/Test-spatial-functions-2-vu-prepare.txt

 CREATE VIEW TestGeospatialMethods_empty_ValFromGeomTemp AS SELECT location.STIsEmpty() FROM TestGeospatialMethods_SPATIALPOINTGEOM_dttemp ORDER BY location.STX;

-CREATE VIEW TestGeospatialMethods_empty_TextFromGeomTemp AS SELECT  location.STIsEmpty() AS Dimension FROM TestGeospatialMethods_SPATIALPOINTGEOG_dttemp ORDER BY location.Lat;
+CREATE VIEW TestGeospatialMethods_empty_TextFromGeomTemp AS SELECT  location.STIsEmpty() AS Dimension FROM TestGeospatialMethods_SPATIALPOINTGEOG_dttemp ORDER BY location.Lat;


unnecessary change, please remove this.

test/JDBC/input/datatypes/Test-spatial-functions-2-vu-prepare.txt

Mohitraj-g · 2026-01-21T11:13:24Z

Add expected output files as well.

Mohitraj-g · 2026-01-21T11:15:04Z

Please fix the PR description.

rishabhtanwar29 · 2026-01-21T14:59:27Z

contrib/babelfishpg_common/sql/upgrades/spatial_types--5.4.0--5.5.0.sql

+		IF geom IS NULL THEN
+		    RETURN NULL;


I think marking the function strict already makes sure to return NULL or NULL input so this check seems unnecessary.

rishabhtanwar29 · 2026-01-21T15:01:27Z

contrib/babelfishpg_common/sql/geography.sql

+    IF geom IS NULL THEN
+        RETURN NULL;


Same as above.

rishabhtanwar29 · 2026-01-21T15:03:26Z

contrib/babelfishpg_common/sql/upgrades/spatial_types--5.4.0--5.5.0.sql

+CREATE OR REPLACE FUNCTION sys.STPerimeter_helper(sys.GEOMETRY)
+        RETURNS float8
+        AS '$libdir/postgis-3','LWGEOM_perimeter2d_poly'
+		LANGUAGE 'c' IMMUTABLE STRICT PARALLEL SAFE;


Let's also add sys.STLength(geom sys.GEOGRAPHY) and sys.STLength_helper(geom sys.GEOGRAPHY) functions here.

rishabhtanwar29 · 2026-01-21T15:09:29Z

contrib/babelfishpg_common/sql/upgrades/spatial_types--5.4.0--5.5.0.sql

 			RETURN geom;
 		ELSE
 			RAISE EXCEPTION 'Expected "POLYGON" at Position 1. The input has %', $1;
 		END IF;


This change should come into spatial_types--5.5.0--5.6.0.sql instead. Lets remove these changes from this file.

rishabhtanwar29 · 2026-01-21T15:11:18Z

contrib/babelfishpg_tsql/antlr/TSqlLexer.g4

 STDIMENSION:                                     'STDimension';
 STDISJOINT:                                      'STDisjoint';
 STDISTANCE:                                      'STDistance';
+STREDUCE:                                        'STReduce';


Let's only add STLENGTH for now. Also, let's not mark the comments as resolved until we actually fix them.

rishabhtanwar29 · 2026-01-21T15:13:01Z

test/JDBC/input/datatypes/Test-spatial-functions-2-vu-verify.sql

@@ -951,4 +951,164 @@ Select CAST(CAST('POINT EMPTY' as varchar(100)) AS geography).STAsText();
 go


Let's also add expected output files.

…_STLENGTH

coveralls · 2026-01-23T06:04:14Z

Pull Request Test Coverage Report for Build 21511153874

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
24 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.03%) to 76.991%

Files with Coverage Reduction	New Missed Lines	%
contrib/babelfishpg_tsql/src/collation.c	1	80.99%
contrib/babelfishpg_tds/src/backend/tds/tdsbulkload.c	23	85.99%

Totals
Change from base Build 21071680503:	0.03%
Covered Lines:	52728
Relevant Lines:	68486

💛 - Coveralls

rishabhtanwar29 · 2026-02-02T11:07:01Z

contrib/babelfishpg_common/sql/upgrades/spatial_types--5.5.0--5.6.0.sql

 -------------------------------------------------------
+-- STLength
+CREATE OR REPLACE FUNCTION sys.STLength(geom sys.GEOMETRY)
+    RETURNS float8


Have we verified whether it is float4 or float8?

yes i have verified it

Gopal Verma added 2 commits January 21, 2026 05:22

Add STLength support for geography and geometry types

09630f7

Add missing test files for STLength spatial function

9c5c286

Signed-off-by: Gopal Verma <[email protected]>

Mohitraj-g closed this Jan 21, 2026

Mohitraj-g reopened this Jan 21, 2026

empty commit

e855e8e

Signed-off-by: Gopal Verma <[email protected]>

Mohitraj-g reviewed Jan 21, 2026

View reviewed changes

rishabhtanwar29 reviewed Jan 21, 2026

View reviewed changes

Gopal Verma added 4 commits January 22, 2026 07:28

Merge remote-tracking branch 'upstream/BABEL_5_X_DEV' into BABEL_6310…

9c5883f

…_STLENGTH

updated code

3a998f5

Fix CI: Add missing fi and enable PostGIS extension for spatial tests

82888f0

Fix precision and add STLength functions to upgrade validation

22808fd

Gopal Verma added 5 commits January 30, 2026 05:36

Update

1aedcc3

Update fix

b82a16f

unnecessary change

7ddecc2

fix in testcases

15e1ca4

fix changes in testcase

8a6544d

rishabhtanwar29 reviewed Feb 2, 2026

View reviewed changes

		@@ -951,4 +951,164 @@ Select CAST(CAST('POINT EMPTY' as varchar(100)) AS geography).STAsText();
		go

Conversation

Gopalverma062 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Function Implementation

Parser Updates

Test Cases

Error Handling

Extended Existing Functionalities

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Mohitraj-g commented Jan 21, 2026

Uh oh!

Mohitraj-g commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21511153874

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Gopalverma062 commented Jan 21, 2026 •

edited

Loading

Mohitraj-g commented Jan 21, 2026 •

edited

Loading

coveralls commented Jan 23, 2026 •

edited

Loading