Fix: preserve trailing spaces for DATABASE in HAS_PERMS_BY_NAME

[DervisAliDuman]

Description

What:
Previously, HAS_PERMS_BY_NAME would incorrectly strip trailing spaces from the @object_name parameter when the securable class was 'DATABASE'.
This caused permission checks to fail when the database name contained trailing spaces.

With this change:
Removed the rtrim() call on cs_as_securable for the 'DATABASE' securable class.
Now Babelfish preserves the exact string provided by the caller, including trailing spaces, aligning behavior with SQL Server.

Why:
SQL Server treats database names with and without trailing spaces as distinct.
Babelfish should match that behavior for accurate permission checks and T-SQL compatibility.

Verification:

CREATE DATABASE [ blank space ];
SELECT HAS_PERMS_BY_NAME(' blank space ', 'DATABASE', 'CREATE FUNCTION');

Result: Permission check now succeeds.

---

Issues Resolved

• Fixes incorrect permission check behavior for databases with trailing spaces.
• Aligns Babelfish behavior with SQL Server semantics for HAS_PERMS_BY_NAME.

---

Test Scenarios Covered

• Use case based:
  Verified that HAS_PERMS_BY_NAME works with database names that include trailing spaces.

• Boundary conditions:
  Tested database names with:

  • Single trailing space
  • Multiple trailing spaces
  • No trailing spaces (control case)

• Negative test cases:
  Verified that permission checks still fail for users without CREATE FUNCTION privilege, regardless of trailing spaces.

• Regression tests:
  Confirmed that other securable classes (OBJECT, SCHEMA, etc.) remain unaffected.

• Minor/Major upgrade tests:
  Initialized Babelfish on a fresh database and verified behavior after restart.

• Performance impact:
  No measurable impact. The change removes unnecessary rtrim() call for 'DATABASE' securable class only.

---

Check List

• Commit signed off per DCO using --signoff
• Change verified locally with sqlcmd on Babelfish-enabled PostgreSQL 17
• Behavior matches SQL Server reference

[coveralls]

Pull Request Test Coverage Report for Build 18468011320

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 76.63%

---

Totals
Change from base Build 18455495732:	0.002%
Covered Lines:	51696
Relevant Lines:	67462

---

💛 - Coveralls

[DervisAliDuman]

Hi @tanyagupta17, @forestkeeper , the tests are passing right now. Could you please review and approve them? Thank you in advance!

[DervisAliDuman]

Hi @pranavJ23 , @rohit01010 , the tests are passing right now. Could you please review and approve them? Thank you in advance!

[pranavJ23]

Hi @DervisAliDuman , thanks for working on this PR, I have a follow-up question:

CREATE DATABASE [  blank space    ];

Can you once confirm if T-SQL allows to make a database name ending with space/tab ?

[DervisAliDuman]

Hi @DervisAliDuman , thanks for working on this PR, I have a follow-up question:

CREATE DATABASE [  blank space    ];

Can you once confirm if T-SQL allows to make a database name ending with space/tab ?

Yes @pranavJ23, you can run these test in your Test space:

DROP DATABASE IF EXISTS [  blank space    ];
CREATE DATABASE [  blank space    ];

SELECT HAS_PERMS_BY_NAME('[  blank space    ]','DATABASE','CREATE FUNCTION');
SELECT HAS_PERMS_BY_NAME('  blank space    ','DATABASE','CREATE FUNCTION');
SELECT HAS_PERMS_BY_NAME('blank space ','DATABASE','CREATE FUNCTION');

Also I would like to share the mssql results with you:

[DervisAliDuman]

Hello @pranavJ23, is this test case legit for you? You can open mssql and run these commands too:

DROP DATABASE IF EXISTS [  blank space    ];
CREATE DATABASE [  blank space    ];

SELECT HAS_PERMS_BY_NAME('[  blank space    ]','DATABASE','CREATE FUNCTION');
SELECT HAS_PERMS_BY_NAME('  blank space    ','DATABASE','CREATE FUNCTION');
SELECT HAS_PERMS_BY_NAME('blank space ','DATABASE','CREATE FUNCTION');

[DervisAliDuman]

Hi @pranavJ23 and @rohit01010 , can you review it pls.

[pranavJ23]

Can this change produce a regression for case when originally database name do not have spaces but we passed spaces while calling HAS_PERMS_BY_NAME function in database name, eg:

create database [hello_db]
go

SELECT HAS_PERMS_BY_NAME('hello_db    ','DATABASE','CREATE FUNCTION');

[DervisAliDuman]

Yes, the old test and my tests combination support that test you wanted.

[pranavJ23]

I agree that tests are there but is the behaviour correct ?
Can we confirm this behaviour with t-sql behaviour once ?

[DervisAliDuman]

As I understand you want original mssql behaviour and I mentioned before with this test:

Isn't this confirmation that you wanted?

[pranavJ23]

Let me clarify it again :

1. Make a db without any trailing spaces:

create database [hello_db]
go

2. call function as

SELECT HAS_PERMS_BY_NAME('hello_db    ','DATABASE','CREATE FUNCTION');

Now we are calling the HAS_PERMS_BY_NAME with database as hello_db with trailing spaces , now this should return 1 as output as per t-sql behaviour, but since with your change you are removing the rtrim() so this could make the result 0 (instead of 1).

Note: in the tests you added contain the database name with spaces and we are comparing that, in the test I am pointing towards, database name does not have any spaces in it's name, but while calling HAS_PERMS_BY_NAME function we are adding spaces in database name

[pranavJ23]

can you explain this change ?

[DervisAliDuman]

Originally there were no trailing space on the right side while creating this database name and it was passing but it shouldn't beacuse it has wrong name withouth spaces. This test was passing beacuse it was rtrim()'ed the spaces. And there are no original databases that can test this bug. So I created My own tests.

[pranavJ23]

Hi @DervisAliDuman , let me know if you have any opinion over: #4128 (comment)

[DervisAliDuman]

Hi @DervisAliDuman , let me know if you have any opinion over: #4128 (comment)

Hi @pranavJ23 , I understand your concern. I just tested the exact scenario you mentioned in SSMS connected to a native SQL Server instance (SQL Server 2022). If we create [hello_db] without spaces, and then call SELECT HAS_PERMS_BY_NAME('hello_db ', 'DATABASE', 'CREATE FUNCTION');, T-SQL actually returns 0, not 1. It strictly matches the string for the DATABASE securable class and does not implicitly trim the input. Therefore, removing rtrim() from Babelfish correctly aligns our behavior with T-SQL without introducing a regression. I have attached the SSMS screenshot for this specific case before as well.

[rohit01010]

This is bit strange, when I tested above query I am also getting 1 in TSQL 2022.

1> SELECT cast(SERVERPROPERTY('ProductVersion') AS varchar(20)) AS ProductVersion, cast(SERVERPROPERTY('ProductLevel') AS varchar(20)) AS ProductLevel,cast(SERVERPROPERTY('Edition') as varchar(40)) AS Edition;
2> GO
ProductVersion       ProductLevel         Edition                                 
-------------------- -------------------- ----------------------------------------
16.0.4236.2          RTM                  Express Edition (64-bit)                

(1 rows affected)
1> CREATE DATABASE [hello_db]
2> go

1> SELECT HAS_PERMS_BY_NAME('hello_db    ','DATABASE','CREATE FUNCTION');
2> GO
           
-----------
          1

(1 rows affected)

@DervisAliDuman Can you please provide results of following queries in your TSQL Instance

SELECT @@VERSION
GO

SELECT cast(SERVERPROPERTY('ProductVersion') AS varchar(20)) AS ProductVersion, cast(SERVERPROPERTY('ProductLevel') AS varchar(20)) AS ProductLevel,cast(SERVERPROPERTY('Edition') as varchar(40)) AS Edition;
GO

CREATE DATABASE [hello_db]
GO

SELECT HAS_PERMS_BY_NAME('hello_db    ','DATABASE','CREATE FUNCTION');
GO