Add new options.md and config-files.md files to replace current config-file and core options docs #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganfsmyth
changed the title
Contributor
|
Deploy preview for babel ready! Built with commit 9fb7f99 |
loganfsmyth
force-pushed
the
options-and-file-overhaul
branch
2 times, most recently
from
3c1e249 to
1c87836
Compare
This was referenced Aug 28, 2018
docs/config-files.md
Outdated
| ``` | ||
| the config will now be entirely ignored, because it is across a package boundary. | ||
|
|
||
| One alternative would be to reate a `.babelrc` in each sub-package that uses ["extends"](options.md#extends) as |
There was a problem hiding this comment.
typo: I suppose this should have been "create" instead of "reate"
docs/config-files.md
Outdated
| directory for Babel is the individual packages), the `babel.config.js` file will not be automatically | ||
| loaded, and users will be required to set the path to it manually. | ||
|
|
||
| Project-wide configs can also be disable by setting ["configFile"](options.md#configFile) to `false`. |
docs/config-files.md
Outdated
| Babel loads `.babelrc` (and `.babelrc.js` / `package.json#babel`) files by searching up the | ||
| directory structure starting from the ["filename"](options.md#filename) being compiled. This can | ||
| be powerful because it allows you to create independent configurations for subsections of | ||
| a repository. File-relative configurations are also [merge](options.md#merging) over top of |
docs/configuration.md
Outdated
| Babel can be configured! Many other tools have similar configs: ESLint (`.eslintrc`), Prettier (`.prettierrc`). | ||
|
|
||
| All Babel API [options](core.md#options) are allowed. However if the option requires JavaScript, you may need to use a `.babelrc.js` file. | ||
| All Babel API [options](options.md) are allowed. However if the option requires JavaScript, you may want to use a Javascript [configuration file](config-files.md). |
There was a problem hiding this comment.
IIRC there should be a comma after "However"
loganfsmyth
force-pushed
the
options-and-file-overhaul
branch
from
1c87836 to
9fb7f99
Compare
danielo515
reviewed
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a pretty good way to split things up. Let me know what you think!