Apply forceEnv option to Babel transformation#379
Merged
danez merged 2 commits intobabel:masterfrom Feb 15, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 81.87% 83.43% +1.56%
==========================================
Files 6 6
Lines 160 163 +3
Branches 35 35
==========================================
+ Hits 131 136 +5
+ Misses 13 12 -1
+ Partials 16 15 -1
Continue to review full report at Codecov.
|
|
What about with the |
Contributor
Author
|
What about it? I tried to think of how |
|
|
This was referenced Feb 16, 2017
This was referenced Mar 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the discussion in #368, this PR applies the
forceEnvoption to the Babel transformation.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
As discussed here, the
forceEnvoption applies to the cacheIdentifier, but does not actually apply to the Babel transformation.What is the new behavior?
The
forceEnvoption now applies to the Babel transformation as well.Does this PR introduce a breaking change?