Skip to content

gzipped files should have .gz as the extension, not .gzip#326

Merged
hiroppy merged 1 commit intobabel:masterfrom
bjornstar:gz-not-gzip
Nov 7, 2016
Merged

gzipped files should have .gz as the extension, not .gzip#326
hiroppy merged 1 commit intobabel:masterfrom
bjornstar:gz-not-gzip

Conversation

@bjornstar
Copy link
Contributor

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
The standard extension for gzipped files is .gz but cachingDirectory causes files to be created with the extension .gzip

What is the new behavior?
cache files are created with the extension .gz

Does this PR introduce a breaking change?

  • Yes
  • No

@codecov-io
Copy link

Current coverage is 80.00% (diff: 100%)

Merging #326 into master will not change coverage

@@             master       #326   diff @@
==========================================
  Files             5          5          
  Lines           140        140          
  Methods          21         21          
  Messages          0          0          
  Branches         30         30          
==========================================
  Hits            112        112          
  Misses           13         13          
  Partials         15         15          

Powered by Codecov. Last update 4eace42...320a16d

1 similar comment
@codecov-io
Copy link

codecov-io commented Nov 7, 2016

Current coverage is 80.00% (diff: 100%)

Merging #326 into master will not change coverage

@@             master       #326   diff @@
==========================================
  Files             5          5          
  Lines           140        140          
  Methods          21         21          
  Messages          0          0          
  Branches         30         30          
==========================================
  Hits            112        112          
  Misses           13         13          
  Partials         15         15          

Powered by Codecov. Last update 4eace42...320a16d

@hiroppy
Copy link
Member

hiroppy commented Nov 7, 2016

Thanks 😄

@hiroppy hiroppy merged commit f86507f into babel:master Nov 7, 2016
@bjornstar bjornstar deleted the gz-not-gzip branch November 7, 2016 05:38
Ognian pushed a commit to Ognian/babel-loader that referenced this pull request Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants