Update README docs for cacheDirectory's actual behaviour#245
Closed
sohkai wants to merge 1 commit intobabel:masterfrom
Closed
Update README docs for cacheDirectory's actual behaviour#245sohkai wants to merge 1 commit intobabel:masterfrom
sohkai wants to merge 1 commit intobabel:masterfrom
Conversation
Member
|
Thanks for the contribution and sorry for the late reply, this works since this commit was merged webpack/loader-utils@1c75aac going to merge this PR by hand. |
Member
|
Merged in 8fa7946 |
Contributor
Author
|
Thanks @danez! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure exactly when the changes were made to fs-cache that outdated the current docs, but given this line in fs-cache, it correctly uses the OS's temp dir regardless of if the query param is
?cacheDirectoryor?cacheDirectory=true(and, in fact, using the query property syntax results in the same behaviour as?cacheDirectory=true).