Skip to content

Build package with node.js v24#23

Open
jtsaito wants to merge 2 commits intomainfrom
nodejs-v24-build
Open

Build package with node.js v24#23
jtsaito wants to merge 2 commits intomainfrom
nodejs-v24-build

Conversation

@jtsaito
Copy link
Contributor

@jtsaito jtsaito commented Jan 5, 2026

Changes:

  • use node.js version 24 for build process

Context:
The current build process with OIDC fails.

It turns out there is an undocumented behaviour for npm publish and actions/setup-node which requires node version 22 or newer (cf. #21 (comment)).

Since the package JSON only requires "node": ">=16.13.0", I suggest trying this update.

Note that the latest version in the change log and pacakge.json is already 2.1.2 but because the last build failed the published version to the registry is still 2.1.1.

Alternatively, we have to roll back to the old publishing process without OIDC and manually rotate the secret.

@jtsaito jtsaito requested a review from mangs as a code owner January 5, 2026 11:31
Copy link
Contributor

@mangs mangs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtsaito I updated this PR to fix the build issues, we should be good to try this out. Thanks for the effort in trying to fix this.

@jtsaito
Copy link
Contributor Author

jtsaito commented Jan 30, 2026

Thank you, @mangs . The corresponding story has been paused for other priorities. I'll continue testing here when it is unpaused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants