圣遗物分解套装筛选的改进和JS引擎的约束 #2319
Merged
圣遗物分解套装筛选的改进和JS引擎的约束 #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaedelcb
pushed a commit
to kaedelcb/better-genshin-impact
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本来只是按文档的讨论（ huiyadanli/bettergi-docs#100 ）来更新一下Config默认值，结果发现套装筛选的时候bug挺多的，赶紧修一波。通过新加的遮罩层显示能清楚地看到还剩一点小问题，主要是图标模型的问题以后再说吧；
圣遗物属性筛选的JS执行时间也加上了3秒的超时限制，希望这里只是用来写属性的匹配规则，因为是逐条运行，如果单条JS都很久，那整体就太慢了，，如果日后有人用神奇的方式来做了导致确实需要很久的超时那再议。把JS的异步外壳去掉改由C#兜底，也有初衷是希望用户别被语法吓到，即使是新手也能尝试写写简单的规则