-
Notifications
You must be signed in to change notification settings - Fork 15
Add documentation for CAPI Management Cluster #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
sd109
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @MaxBed4d - thanks for making a start on this! In general I'd like to avoid making these docs specific to SKC wherever possible so I've left a few comments about that in various places. I've also suggested a few corrections on things which aren't necessarily applicable to standalone CAPI management clusters.
|
This config should now also include an updated web UI for the docs. It has been tested locally and all the formatting looks to be working correctly. |
c81b8d1 to
987cbb8
Compare
|
When we last discussed this in platforms, granted a few years back, we were worried on how we maintain these and keep them in-sync with the Azimuth docs. I don't disagree we need these, but I am hoping we can make it DRY-er vs the existing Azimuth docs. |
JohnGarbutt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of my comments are very small niggles, this is looking pretty good.
I do worry about the resource constraints section... its a very "it depends" sort of a question.
sd109
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Max, looking like it's getting better for sure. A few suggestions from me.
Co-authored-by: Scott Davidson <[email protected]>
No description provided.