Re-Enable Console Pipe Functionality#24963
Merged
Nyeriah merged 7 commits intoazerothcore:masterfrom Mar 13, 2026
Merged
Conversation
Fix Pipe-Functionality
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables Windows worldserver CLI command input when stdin is redirected (pipes), while preserving the Unicode-capable ReadConsoleW path for interactive consoles (regression from #24725 / issue #13203 context).
Changes:
- Detects whether stdin is a real Windows console via
GetConsoleMode. - Uses
ReadConsoleW+ UTF-16→UTF-8 conversion for real consoles; falls back tostd::getline(std::cin, ...)for redirected input. - Stops the server on redirected-input EOF to mirror the existing EOF shutdown behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added iostream include for input/output operations.
update to upstream
fix(Core/Spells): Port SPELL_ATTR3_INSTANT_TARGET_PROCS cascade proc …
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Nyeriah
approved these changes
Mar 13, 2026
trolloks
pushed a commit
to trolloks/azerothcore-cata
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Pipe-Functionality
Changes Proposed:
This PR fixes an issue introduced in #24725 where console input was broken for environments using redirected pipes on windows (in my case: CubeCoders AMP).
Added a check using GetConsoleMode to detect if the server is running in a real interactive Windows console.
This ensures that pipes can still send commands to the server while preserving the new Unicode support for real terminals.
This PR proposes changes to:
AI-assisted Pull Requests
Important
While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.
Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.
ChatGPT helped me with this fix.
Issues Addressed:
charinput #13203 while keeping old pipe functionality.Tests Performed:
Piped Console works again (tested with AMP - CubeCoders).
Also tested with normal console:
.lookup spell höhnon-latin chars:

How to Test the Changes:
use any non-latin character in console.
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.