You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to be very clear about this: I did not test this, I do not even really know how to test this feature.
All I did was take the code from libcamera_device_apply_controls and more-or-less copy/paste it here with the variables changed so that it updates the existing controls instead of overwriting them. This fixes the error and I can now stream video with libcamera0.7, but as far as I know I don't rely on this feature and I could have just commented out line 83 and it would work just as well for me.
So thank you for this PR, so I could spot my error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206 (maybe).
I want to be very clear about this: I did not test this, I do not even really know how to test this feature.
All I did was take the code from
libcamera_device_apply_controlsand more-or-less copy/paste it here with the variables changed so that it updates the existing controls instead of overwriting them. This fixes the error and I can now stream video with libcamera0.7, but as far as I know I don't rely on this feature and I could have just commented out line 83 and it would work just as well for me.