-
Notifications
You must be signed in to change notification settings - Fork 120
feat: optionally apply github-build-setup steps to additional jobs
#2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: optionally apply github-build-setup steps to additional jobs
#2070
Conversation
github-build-setup steps to additional jobs.github-build-setup steps to additional jobs
|
Thanks for the submission! This makes sense, and I understand the motivation, but I'm not sure always applying this is the best solution. The original motivation for this feature was to install package dependencies for builds - for example, a user needed to fetch a custom copy of Lua. This is a bit too heavy to apply to all steps if it's only neeed for builds; it would significantly add to the time it takes to run the full action without any benefit. How about adding a new setting where we configure what phases to add the |
|
@mistydemeo that suggestion makes sense to me. Happy to make those changes. |
|
Thank you! I appreciate it. Happy to review when you’re ready. |
b597511 to
52836fa
Compare
github-build-setup steps to additional jobsgithub-build-setup steps to additional jobs
52836fa to
12851f7
Compare
|
Alright, I think this is ready for review @mistydemeo. I appreciate your assistance! |
|
I'll review soon - sorry for the delay! I've been busy. |
mistydemeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your understanding on my delay getting to this. Your PR came in just as I was moving to a new home, and it took me awhile after the big stressful move to have the energy for OSS again. 😅
We've made some changes to the base branch, so this will need a rebase. I've made one other suggestion too.
For some use cases, such as using private Git crate dependencies in a project's Cargo.toml manifest, Github Actions requires a certain amount of ceremony to alias the private repo's Git URL to to something that can be cloned using an access token. For the `build-local-artifacts` job, this can be accomplished by adding the authentication step in the `github-build-setup` YML file. There are additional jobs that necessitate these credentials be set, mainly the `plan`, `build-global-artifacts`, and `host`. This appears to be due to the fact they invoke `cargo metadata` (which attempts to pull dependencies). Support these use-cases by introducing a `github-build-setup-jobs` collection which allows users to opt-in to including the `github-build-setup` steps in various jobs. Fixes axodotdev#2065
12851f7 to
9033ae3
Compare
|
@mistydemeo no worries at all. Moving can be a lot, and OSS maintenance can be thankless at times. I have rebased and eliminated the duplicated rules. |
For some use cases, such as using private git crate dependencies in a project's Cargo.toml manifest, Github Actions requires a certain amount of ceremony to alias the private repo's Git URL to to something that can be cloned using an access token. For the
build-local-artifactsjob, this can be accomplished by adding the authentication step in thegithub-build-setupYML file.There are additional jobs that necessitate these credentials be set, mainly the
plan,build-global-artifacts, andhost. This appears to be due to the fact they invokecargo metadata(which attempts to resolve dependencies).Support these use-cases by introducing a
github-build-setup-jobscollection which allows users to opt-in to including thegithub-build-setupsteps in various jobs.Fixes #2065