backend: log trim @io_u to io_hist even do_verify=0#2105
Merged
Conversation
--do_verify=0 blocks TRIM command being issued even if --trim_percentage=<%> is given properly. fio generates a TRIM command based on the logged @io_u in io_hist based on the percentage value. If --do_verify=0, @io_u will never be logged into io_hist so that TRIM @io_u will never be generated. TRIM itself is usually useful when verify operations come together, but it should have been able to be issued regardless to the verify. This patch enabled WRITE @io_u logging to io_hist when --do_verify=0 case. Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--do_verify=0 blocks TRIM command being issued even if --trim_percentage=<%> is given properly. fio generates a TRIM command based on the logged @io_u in io_hist based on the percentage value. If --do_verify=0, @io_u will never be logged into io_hist so that TRIM @io_u will never be generated. TRIM itself is usually useful when verify operations come together, but it should have been able to be issued regardless to the verify. This patch enabled WRITE @io_u logging to io_hist when --do_verify=0 case.