SQS: Properly handle Errors in listeners#1383
Conversation
|
Hey @isaacvando, thanks for the PR!
I'm happy with the tests you added, so unless you'd like to test an specific flow with an integration test, I don't think we'd need specific tests to assert correct handling for Error. If you do think there's a flow you'd like to test though, feel free to. On a quick search on the codebase for While Totally up to you though, happy to merge this PR as is and open a new issue for that. Please let me know your thoughts, thanks. |
|
Great, @tomazfernandes! I will be out of office for a while so I think it would be best to go ahead and merge the PR now. Thanks! |
|
Thanks for the PR @isaacvando, looking forward to more! I've opened the issue for the remaining Exceptions: |
📢 Type of change
📜 Description
I updated the listener adapters to catch Throwable instead of Exception so that
ErrorHandlers can handle Throwables as expected.💡 Motivation and Context
Fixes #1379.
💚 How did you test it?
I added unit tests to the classes I modified and tested the change locally within my own project against the reproduction in the issue.
I would be happy to add an integration test if appropriate. If so could you give me some direction about your preferences for that?
📝 Checklist
🔮 Next steps