Add ExponentialBackoffErrorHandler to manage message visibility tim…

[brun0-4ugusto]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

New ExponentialBackoffErrorHandler to change message visibility timeout exponentially based on the number of receive Message Count

💡 Motivation and Context

As mentioned in (#1313), this enhancement enables reporting an error back to AWS SQS by exponentially increasing the message's visibility timeout, allowing it to be retried.

See #1314

💚 How did you test it?

Unit test, Integration test, manual tests with a sample application

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• I updated reference documentation to reflect the change
• All tests passing
• No breaking changes

🔮 Next steps

• Update sample application

[tomazfernandes]

Looking great @brun0-4ugusto and @rafaelcgpava!

I left a few of comments in the code, please let me know if they make sense.

We can add some debug or trace logs so we can follow whether visibility change was successful and to what value it was changed to for a given message id.

We also need to decide what happens if visibility change fails for a given message or set of messages - we should at least log the error clearly with context.

Abstractions

Regarding abstractions, I can see where we could benefit from code reuse, but since it's not too much logic perhaps some duplication is ok?

We can also have a ErrorHandlerVisibilityHelper class with some utility methods.

Please let me know your thoughts on all of this, thanks!

[brun0-4ugusto]

Hello @tomazfernandes,

I hope you’re doing well. We have implemented the requested changes—they were excellent ideas! We also took the opportunity to incorporate the new ErrorHandlerVisibilityHelper into the ImmediateRetryAsyncErrorHandler class. Please let us know if you have any further suggestions for improvement.

Thank you again! 😸

[tomazfernandes]

Thanks for the changes, it's looking good!

Left a couple of comments. Also, please add docs on the new error handler.

[brun0-4ugusto]

Hi @tomazfernandes ,

Thank you for your feedback and comments. We have addressed the points you raised and added documentation for the new error handler. Please let us know if you have any further suggestions or questions.

[tomazfernandes]

Thanks for the PR @brun0-4ugusto and @rafaelcgpava!

I have two more issues in mind regarding error handling:

• Create a LinearBackOffErrorHandler
• Create a BackOffErrorHandlerFactory, where we can set the parameters we want and it'll return the proper implementation.

What do you think? Would you like to contribute those as well?

Let me know your thoughts, thanks!

[brun0-4ugusto]

Hi @tomazfernandes Thanks for the review!
We’d be happy to contribute those as well! 😺

[brun0-4ugusto]

Hi @tomazfernandes, how are you?
Apologies for the delay. I’ve submitted a PR that provides a LinearBackOffErrorHandler and additional exponential jitter strategies. I’ll send another PR with the factory shortly. (#1422 )