This repository was archived by the owner on Aug 20, 2024. It is now read-only.
Clearer error message for known-but-unsupported vs. unknown sign-in providers #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et supported by pidgin-chime From the JavaScript of app.chime.aws, there are providers called 'okta', 'federate', and 'sso' which we do not yet support.
|
folks, is there any plan to start supporting presently unsupported providers (namely looking for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix spelling of 'scrape'/'scraping' in source and comments
Include unknown sign-in provider type in user-visible message
Distinct error message for sign-in providers that are known but not yet supported by pidgin-chime
From the JavaScript of app.chime.aws, there are providers called 'okta',
'federate', and 'sso' which we do not yet support.
By submitting this pull request, I confirm that my contribution is made under the terms of the LGPL 2.1.