This repository was archived by the owner on Aug 20, 2024. It is now read-only.
Add attachment upload support for chats #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gqmelo
force-pushed
the
attachment-upload-chat
branch
from
298b1b3 to
aab4675
Compare
gqmelo
force-pushed
the
attachment-upload-chat
branch
from
aab4675 to
3244e6f
Compare
On Pidgin a file can be uploaded through `Conversation->More->Send File` menu.
gqmelo
force-pushed
the
attachment-upload-chat
branch
from
3244e6f to
8895e17
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: This adds the ability to attach a file in a chat. On Pidgin a file can be uploaded through
Conversation->More->Send Filemenu.After re-imaging my laptop, I realized I was using this patch for months and it has been worked fine since then. I didn't like much the fact that
chime_send_file_chatrecieves aChimeObject. I don't how much this could be a problem.By submitting this pull request, I confirm that my contribution is made under the terms of the LGPL 2.1.