Emit warning-level logs to syslog when log directory is unset #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
No code changes, just relocating the module in preparation for the next commit. Signed-off-by: James Bornholt <[email protected]>
Signed-off-by: James Bornholt <[email protected]>
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Error
Contributor
|
Plan to finish review here tomorrow morning. Needed to learn a bit about |
Signed-off-by: James Bornholt <[email protected]>
Signed-off-by: James Bornholt <[email protected]>
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Error
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
reviewed
Jul 19, 2023
Contributor
dannycjones
left a comment
dannycjones
left a comment
There was a problem hiding this comment.
Thanks James, this looks great and I'm glad to have this as the default if logging is not configured. The additional comments in the last commit also helped a lot.
The main concern I have is that it will become a file that most will not want to touch, so I'd like to make it as accessible as possible. The comments are along these lines.
Signed-off-by: James Bornholt <[email protected]>
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
approved these changes
Jul 20, 2023
Contributor
dannycjones
left a comment
dannycjones
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for the updated comments, very clear.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
We disabled logging to a file by default in #373. But we'd still like to have a default home for high-severity messages, which is exactly what syslog is for.
This PR is the bare minimum to get
tracing-style structured logging into syslog. I hardcoded the verbosity towarn,awscrt=offand didn't think too hard about configuration: the syslog logger is on whenever the--log-directoryflag isn't set. Because I didn't think too hard about it, I also didn't update docs/LOGGING.md yet.This PR is two commits:
main.rsto its own file, just because it was getting big. No other code changes here.logging.rs.Does this change impact existing behavior?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).