Skip to content

Conversation

@scottschreckengaust
Copy link
Member

@scottschreckengaust scottschreckengaust commented Jun 30, 2025

Issue #, if available:

#262

Description of changes:

Add short-term and long-term examples:

  • ASIAIOSFODNN7EXAMPLE
  • ASIAI44QH8DHBEXAMPLE
  • AKIAI44QH8DHBEXAMPLE

git-secrets/git-secrets

Lines 242 to 243 in 5357e18

add_config 'secrets.allowed' 'AKIAIOSFODNN7EXAMPLE'
add_config 'secrets.allowed' "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"

from https://docs.aws.amazon.com/cli/v1/userguide/cli-configure-files.html:

short term:

[default]
aws_access_key_id=ASIAIOSFODNN7EXAMPLE
aws_secret_access_key=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY
aws_session_token = IQoJb3JpZ2luX2IQoJb3JpZ2luX2IQoJb3JpZ2luX2IQoJb3JpZ2luX2IQoJb3JpZVERYLONGSTRINGEXAMPLE

[user1]
aws_access_key_id=ASIAI44QH8DHBEXAMPLE
aws_secret_access_key=je7MtGbClwBF/2Zp9Utk/h3yCo8nvbEXAMPLEKEY
aws_session_token = fcZib3JpZ2luX2IQoJb3JpZ2luX2IQoJb3JpZ2luX2IQoJb3JpZ2luX2IQoJb3JpZVERYLONGSTRINGEXAMPLE```

long-term:

[default]
aws_access_key_id=AKIAIOSFODNN7EXAMPLE
aws_secret_access_key=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY

[user1]
aws_access_key_id=AKIAI44QH8DHBEXAMPLE
aws_secret_access_key=je7MtGbClwBF/2Zp9Utk/h3yCo8nvbEXAMPLEKEY

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scottschreckengaust scottschreckengaust changed the title Fix/add more examples during register aws fix: add more examples during register aws Jun 30, 2025
@scottschreckengaust scottschreckengaust force-pushed the fix/add-more-examples-during-register-aws branch from f8b2aeb to b8e207b Compare July 1, 2025 01:24
@scottschreckengaust
Copy link
Member Author

scottschreckengaust commented Jul 1, 2025

Prior to merging, consider having the https://docs.github.com/en/code-security/secret-scanning/introduction/supported-secret-scanning-patterns#default-patterns for Secret type aws_temporary_access_key_id be updated so a false positive "Amazon AWS Temporary Access Key ID" https://github.com/OWNER/REPO/security/secret-scanning doesn't occur for the new introduced secrets to allow.

Publicly leaked secret

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant