Skip to content

Feat: added support for distinct variable files per region per account in terraform pipelines #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbkok merged 7 commits into from
Jan 18, 2024
Merged

Feat: added support for distinct variable files per region per account in terraform pipelines #662

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a0e3261
Feature: added support for distinct variable files per region per acc…
igordust Oct 16, 2023
96d43a5
Fixed Markdown for linting
igordust Oct 16, 2023
24b789c
Fixed Markdown for linting
igordust Oct 16, 2023
4f1fab1
Spell typo
igordust Oct 16, 2023
030ab0e
Spell typo
igordust Oct 16, 2023
c260365
Update src/lambda_codebase/initial_commit/bootstrap_repository/adf-bu…
igordust Oct 31, 2023
ed307bb
Merge branch 'master' into feature/terraform_multiregion_variables
sbkok Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions docs/user-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,7 +1164,7 @@ pipelines:
4. Add variable definition to `tf/variables.tf` file and variable values to
`tfvars/global.auto.tfvars`.

- Local variables (per account) can be configured using the following
- Local variables (per account and per region) can be configured using the following
naming convention

```txt
Expand All @@ -1176,8 +1176,11 @@ pipelines:
│
└───111111111111 <-- this folders contains variable files related to
│ │ the account
│ └──────│ local.auto.tfvars <-- this file contains variables related
│ │ to the account
│ └──────│ local.auto.tfvars <-- this file contains variables
│ │ related to the account
│ └───eu-west-1
│ └────── region.auto.tfvars <-- this file contains
│ variables related to the account and the region
│
└───222222222222
└──────│ local.auto.tfvars
Expand All @@ -1190,6 +1193,21 @@ pipelines:
7. Pipeline contains a manual approval step between Terraform plan and
Terraform apply. Confirm to proceed.

**Note**:
The pipeline leverages the terraform behavior on reading *.local.tfvars files,
so the latter file in lexicographical order overrides variables already defined
in preceding files.

Given the structure above, terraform can possibly find 3 files:

- `global.auto.tfvars`
- `local.auto.tfvars`
- `region.auto.tfvars`

and it means that `region.auto.tfvars` can override variables passed in
`local.auto.tfvars`, that in turn can override variables passed in
`global.auto.tfvars`.

Terraform state files are stored in the regional S3 buckets in the deployment
account. One state file per account/region/module is created.

Expand Down
3 changes: 3 additions & 0 deletions ...e/initial_commit/bootstrap_repository/adf-build/shared/helpers/terraform/adf_terraform.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ tfinit(){
if [ -d "${CURRENT}/tfvars/${TF_VAR_TARGET_ACCOUNT_ID}" ]; then
cp -R "${CURRENT}/tfvars/${TF_VAR_TARGET_ACCOUNT_ID}"/* "${CURRENT}/tmp/${TF_VAR_TARGET_ACCOUNT_ID}-${AWS_REGION}"
fi
if [ -d "${CURRENT}/tfvars/${TF_VAR_TARGET_ACCOUNT_ID}/${AWS_REGION}" ]; then
cp -R "${CURRENT}/tfvars/${TF_VAR_TARGET_ACCOUNT_ID}/${AWS_REGION}"/* "${CURRENT}/tmp/${TF_VAR_TARGET_ACCOUNT_ID}-${AWS_REGION}"
fi
if [ -f "${CURRENT}/tfvars/global.auto.tfvars" ]; then
cp -R "${CURRENT}/tfvars/global.auto.tfvars" "${CURRENT}/tmp/${TF_VAR_TARGET_ACCOUNT_ID}-${AWS_REGION}"
fi
Expand Down