Skip to content

[Bug] Fix custom pipeline type configuration not loaded #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbkok merged 3 commits into from
Apr 19, 2023
Merged

[Bug] Fix custom pipeline type configuration not loaded #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf63f5a
[Bug] Fix custom pipeline type not loaded
lydialim Feb 28, 2023
23f5a3d
Merge branch 'awslabs:master' into master
lydialim Apr 3, 2023
4be87f6
Fix pipeline_type test cases
Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...mbda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def __init__(
pipeline_type = (
stack_input['pipeline_input']
.get('params', {})
.get('type', DEFAULT_PIPELINE)
.get('pipeline_type', DEFAULT_PIPELINE)
.lower()
)

Expand Down
3 changes: 1 addition & 2 deletions ...mmit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
def test_pipeline_generation_fails_if_pipeline_type_is_not_specified(mock):
stack_input = {"pipeline_input": {"params": {}}}
stack_input["pipeline_input"]["name"] = "test-stack"
stack_input["pipeline_input"]["params"]["type"] = "fail"
stack_input["pipeline_input"]["params"]["pipeline_type"] = "fail"
app = core.App()
with pytest.raises(ValueError):
pipeline_stack = PipelineStack(app, stack_input)
Expand All @@ -35,7 +35,6 @@ def test_pipeline_generation_works_when_no_type_specified(mock):
def test_pipeline_generation_works_when_no_type_specified(mock):
stack_input = {"pipeline_input": {"params": {}}}
stack_input["pipeline_input"]["name"] = "test-stack"
stack_input["pipeline_input"]["params"]["type"] = "Default"

app = core.App()
PipelineStack(app, stack_input)
Expand Down