Introduce CSpell linter #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 16, 2022 12:11
…to change that throughout the repo to management or main
sbkok
requested changes
Dec 16, 2022
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Thanks for adding this so quickly!
This well help a lot with reviewing code and ensuring typos don't accidentally end up in logical resource names as you mentioned.
I also agree on the inclusive wording. I worked on a branch a while ago to change the master account references into management account (in the code mainly), but I parked that until we can start working on the next major version.
...sitory/adf-bootstrap/deployment/lambda_codebase/pipeline_management/create_or_update_rule.py
Outdated
Show resolved
Hide resolved
StewartW
previously approved these changes
Dec 16, 2022
Contributor
StewartW
left a comment
StewartW
left a comment
There was a problem hiding this comment.
Looks good. Great addition. Ironic spelling mistake in the PR title is intentional yeah ;)
sbkok
approved these changes
Dec 20, 2022
StewartW
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Describe why you are proposing these changes
Issue #, if available:
For example, to avoid typo's such as:
#567
What?
Description of changes:
/lintersWhat is NOT covered.
Changing 'Master' to 'Management'. This is still used at many places in this repository and changing this will have an impact on current installs. Best to tackle that in the next major version of ADF.
By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.