Fix permissions to allow CodeBuild as a deployment provider #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** The CloudFormation role that is used to deploy the pipelines was only allowing CodeBuild projects which name started with `adf-build-`. However, it should also allow `adf-deploy-` resources, as that is how the CodeBuild project is named when it is used as a deployment provider. **What?** Added the `adf-deploy-*` project name for CodeBuild projects deployed by the pipeline generation process.
javydekoning
approved these changes
Dec 14, 2022
StewartW
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The CloudFormation role that is used to deploy the pipelines was only allowing CodeBuild projects which name started with
adf-build-. However, it should also allowadf-deploy-resources, as that is how the CodeBuild project is named when it is used as a deployment provider.What?
Added the
adf-deploy-*project name for CodeBuild projects deployed by the pipeline generation process.By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.