Add clean-up of stale deployment map files in the pipeline bucket #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javydekoning
previously approved these changes
Dec 9, 2022
sbkok
force-pushed
the
fix/clean-up-old-deployment-maps
branch
from
6ed93b6 to
30cb204
Compare
**Why?** The identify-out-of-date-pipelines process will iterate over the S3 files and delete the stale pipelines that are no longer defined. However, if you delete a deployment map file, the old deployment map would still exist in the pipelines bucket. Which will put the identify-out-of-date-pipeline process in the wrong direction, as it will think that these pipelines are still active. **What?** Updated the sync to S3 process to delete stale files in the S3 bucket, so deleted deployment map files are also deleted in the pipeline bucket. Also added `DeleteObject` permissions to the CodeBuild Pipeline provisioner, such that it can perform the required S3 calls.
sbkok
force-pushed
the
fix/clean-up-old-deployment-maps
branch
from
30cb204 to
efd1b2f
Compare
Collaborator
Author
|
Also added |
javydekoning
approved these changes
Dec 9, 2022
StewartW
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The identify-out-of-date-pipelines process will iterate over the S3 files and delete the stale pipelines that are no longer defined.
However, if you delete a deployment map file, the old deployment map would still exist in the pipelines bucket. Which will put the identify-out-of-date-pipeline process in the wrong direction, as it will think that these pipelines are still active.
What?
Instructing the sync to S3 process to delete stale files in the S3 bucket, so deleted deployment map files are also deleted in the pipeline bucket.
By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.