Skip to content

Fix CodePipeline source account id lookup to support missing key #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbkok merged 1 commit into from
Dec 9, 2022
Merged

Fix CodePipeline source account id lookup to support missing key #561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 42 additions & 13 deletions ...itial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,33 +280,62 @@ def _generate_configuration(self): #pylint: disable=R0912, R0911, R0915
raise Exception(f"{self.provider} is not a valid provider")

def _generate_codepipeline_access_role(self): # pylint: disable=R0911
account_id = self.map_params['default_providers']['source']['properties']['account_id']
account_id = (
self.map_params['default_providers']['source']
.get('properties', {})
.get('account_id', '')
)

if self.provider == "CodeCommit":
return f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{account_id}:role/adf-codecommit-role"
if self.provider == "GitHub":
return None
if self.provider == "CodeStarSourceConnection":
return None
if self.provider == "CodeBuild":
return None
if self.provider == "CodeCommit":
return (
f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{account_id}:"
"role/adf-codecommit-role"
)
if self.provider == "S3" and self.category == "Source":
# This could be changed to use a new role that is bootstrapped, ideally we rename adf-cloudformation-role to a generic deployment role name
return f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{account_id}:role/adf-codecommit-role"
return (
f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{account_id}:"
"role/adf-codecommit-role"
)
if self.provider == "S3" and self.category == "Deploy":
# This could be changed to use a new role that is bootstrapped, ideally we rename adf-cloudformation-role to a generic deployment role name
return f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{self.target['id']}:role/adf-cloudformation-role"
# This could be changed to use a new role that is bootstrapped,
# ideally we rename adf-cloudformation-role to a
# generic deployment role name
return (
f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{self.target['id']}:"
"role/adf-cloudformation-role"
)
if self.provider == "ServiceCatalog":
# This could be changed to use a new role that is bootstrapped, ideally we rename adf-cloudformation-role to a generic deployment role name
return f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{self.target['id']}:role/adf-cloudformation-role"
# This could be changed to use a new role that is bootstrapped,
# ideally we rename adf-cloudformation-role to a
# generic deployment role name
return (
f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{self.target['id']}:"
"role/adf-cloudformation-role"
)
if self.provider == "CodeDeploy":
# This could be changed to use a new role that is bootstrapped, ideally we rename adf-cloudformation-role to a generic deployment role name
return f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{self.target['id']}:role/adf-cloudformation-role"
# This could be changed to use a new role that is bootstrapped,
# ideally we rename adf-cloudformation-role to a
# generic deployment role name
return (
f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{self.target['id']}:"
"role/adf-cloudformation-role"
)
if self.provider == "Lambda":
# This could be changed to use a new role that is bootstrapped, ideally we rename adf-cloudformation-role to a generic deployment role name
# This could be changed to use a new role that is bootstrapped,
# ideally we rename adf-cloudformation-role to a
# generic deployment role name
return None
if self.provider == "CloudFormation":
return f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{self.target['id']}:role/adf-cloudformation-role"
return (
f"arn:{ADF_DEPLOYMENT_PARTITION}:iam::{self.target['id']}:"
"role/adf-cloudformation-role"
)
if self.provider == "Manual":
return None
raise Exception(f'Invalid Provider {self.provider}')
Expand Down