Fix syncing to S3 without a prefix #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** When the sync_to_s3.py script is asked to sync files without a prefix set, it will instruct the S3 list-objects-v2 API to list all objects with the prefix "/". This does not return anything. Hence the script thinks it needs to upload the files as they are missing. **What?** * Added logic to only add the prefix if set. * Added test to validate that the lookup without a prefix works as instructed.
StewartW
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When the
sync_to_s3.pyscript is asked to sync files without a prefix set, it will instruct the S3 list-objects-v2 API to list all objects with the prefix"/". This does not return anything. Hence the script thinks it needs to upload the files as they are missing.What?
By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.