Fix store ADF config before it needs to be read the first time #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** After deploying ADF for the first time, it will need to store the adfconfig.yml values in the AWS Systems Manager Parameter Store. Such that the logic inside the account bootstrap and account management state machines can execute correctly. At the moment, the config is written after the Step Functions are triggered by syncing account configurations to S3. This will fail on the read of the `config` parameter. **What?** Adding another step that will only store the configuration values in the ADF Bootstrap CodeBuild execution. Before it copies the files that would trigger the account management and account bootstrapping state machines.
StewartW
approved these changes
Oct 12, 2022
javydekoning
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
After deploying ADF for the first time, it will need to store the
adfconfig.ymlvalues in the AWS Systems Manager Parameter Store. Such that the logic inside the account bootstrap and account management state machines can execute correctly.At the moment, the config is written after the Step Functions are triggered by syncing account configurations to S3. This will fail on the read of the
configparameter.What?
Adding another step that will only store the configuration values in the ADF Bootstrap CodeBuild execution. Before it copies the files that would trigger the account management and account bootstrapping state machines.
By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.