Fix stale pipeline deletion #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** At the moment, the input of the State Machine invocation that is handling delete operations is unwrapping the `pipelines_to_be_deleted` from the input. While the pipeline deletion State Machine also tries to do that. **What?** Iterating over the input elements directly instead in the pipeline deletion State Machine.
**Why?** At the moment, when it determines which pipelines need to be deleted, it will also delete the parameters. However, if the deletion fails, the parameters have been deleted and it will not be able to detect that the stack needs to be deleted still. **What?** Moved the deletion of the SSM Parameters to the pipeline deletion state machine.
sbkok
force-pushed
the
fix/pipeline-deletion
branch
from
5d95a84 to
6fc3efa
Compare
StewartW
approved these changes
Sep 27, 2022
javydekoning
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two blockers with the stale pipeline deletion process:
Fix iterating over pipelines that need to be deleted:
Why?
At the moment, the input of the State Machine invocation that is handling
delete operations is unwrapping the
pipelines_to_be_deletedfrom the input.While the pipeline deletion State Machine also tries to do that.
What?
Iterating over the input elements directly instead in the pipeline deletion
State Machine.
Delete pipeline regions SSM Parameters after successful CloudFormation delete stack operation:
Why?
At the moment, when it determines which pipelines need to be deleted, it will
also delete the parameters.
However, if the deletion fails, the parameters have been deleted and it will
not be able to detect that the stack needs to be deleted still.
What?
Moved the deletion of the SSM Parameters to the pipeline deletion state
machine.
By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.