Fix pipeline generation policies #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** With a recent PR, an attempt was made to restrict the `iam:PassRole` permissions for the pipeline generator. However, since ADF supports configuring which role to use, this would introduce a breaking change. **What?** Reverting to the previous policy of `iam:PassRole`. Plan is to address this in the next major ADF release.
**Why?** The policy in the pipeline management attached to the CloudFormation role does not allow it to DeleteStack or UpdateTerminationProtection. As those were using the RequestTag condition that is not compatible with these API calls. Additionally, the `iam:TagResource` action does not exist. **What?** For the `DeleteStack` and `UpdateTerminationProtection` actions, it is updated to use the `iam:ResourceTag` condition instead. While the `iam:TagResource` action got replaced with `iam:TagPolicy` and `iam:TagRole` actions.
StewartW
approved these changes
Sep 22, 2022
javydekoning
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
iam:PassRolepermissions for the pipeline generator. However, since ADF supports configuring which role to use, this would introduce a breaking change.DeleteStackorUpdateTerminationProtection.As those were using the RequestTag condition that is not compatible with these API calls.iam:TagResourceaction does not exist.What?
iam:PassRole. Plan is to address this in the next major ADF release.DeleteStackandUpdateTerminationProtectionactions, it is updated to use theiam:ResourceTagcondition instead.iam:TagResourceaction got replaced withiam:TagPolicyandiam:TagRoleactions.By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.