Fix updating account alias when needed #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** At the moment, the account management state machine will attempt to add the specified alias to the account whether it is present or not. In case the alias already exists, it will fail. **What?** This change will ensure the aliases configured on the account are removed when they are no longer configured (you can only have one, but the API supports multiple). It will then add the alias if the alias that needs to be present is missing.
javydekoning
approved these changes
Aug 31, 2022
Contributor
javydekoning
left a comment
javydekoning
left a comment
There was a problem hiding this comment.
Thanks Simon, makes more sense like this.
StewartW
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
At the moment, the account management state machine will attempt to add the specified alias to the account whether it is present or not.
In case the alias already exists, it will fail.
What?
This change will ensure the aliases configured on the account are removed when they are no longer configured (you can only have one, but the API supports multiple). It will then add the alias if the alias that needs to be present is
missing.
Updated maximum number of attempts in the State Machines to max 10, as 30 would imply multiple days of retries.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.