Fix ADF State Machines #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** In PR awslabs#513, an error was introduced which broke the syntax of the State Machine definition. While investigating, I discovered a number of other improvements that might help, addressing these in this change. **What?** * Fixing missing and redundant commas in retry logic. * Moving roles and other properties of State Machines to the beginning, so they don't float around at the end of the state machine definition. * Enabled tracing on state machines. * Updated name of Account Bootstrapping state machine.
javydekoning
approved these changes
Aug 31, 2022
StewartW
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
In PR #513, an error was introduced which broke the syntax of the State Machine definition.
While investigating, I discovered a number of other improvements that might help, addressing these in this change.
What?
don't float around at the end of the state machine definition.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.