Fix permission to update termination protection on pipeline stacks #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** After updating the CloudFormation template for a ADF pipeline, it tries to update the termination protection flag on the stack. This will fail as the permissions are not configured yet. The failure it returned was: > 2022-08-30 14:22:24,295 | ERROR | cloudformation | 111111111111 | adf-pipeline-some-pipeline, Error: An error occurred (AccessDenied) when > calling the UpdateTerminationProtection operation: User: > arn:aws:sts::111111111111:assumed-role/adf-global-base-deploymen-PipelineManagementCodeBu-xxxxxxxxxxxxx/AWSCodeBuild-xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx > is not authorized to perform: cloudformation:UpdateTerminationProtection on resource: > arn:aws:cloudformation:eu-west-1:111111111111:stack/adf-pipeline-some-pipeline/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx > because no identity-based policy allows the cloudformation:UpdateTerminationProtection action | (cloudformation.py:230) **What?** Adding permission to call the CloudFormation UpdateTerminationProtection API.
StewartW
reviewed
Aug 31, 2022
| runtime-versions: | ||
| python: 3.9 | ||
| nodejs: 14 | ||
| pre_build: |
Contributor
There was a problem hiding this comment.
Why has this been removed?
Collaborator
Author
There was a problem hiding this comment.
As the next lines are installation steps, not pre-build commands.
This has always been a pre-build step before, so not something that was introduced incorrectly.
I just figured it makes more sense to put it in the install step instead, as that is what it is doing.
StewartW
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
After updating the CloudFormation template for a ADF pipeline, it tries to update the termination protection flag on the stack. This will fail as the permissions are not configured yet. The failure it returned was:
What?
Adding permission to call the CloudFormation UpdateTerminationProtection API.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.