Skip to content

Add missing permission to assume Cross-Account-Org R/O role #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbkok merged 2 commits into from
Aug 31, 2022
Merged

Add missing permission to assume Cross-Account-Org R/O role #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
553b494
Add missing permission to assume Cross-Account-Org R/O role
sbkok Aug 30, 2022
add3153
Add empty lines between resources in pipeline management cfn template
sbkok Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...base/initial_commit/bootstrap_repository/adf-bootstrap/deployment/pipeline_management.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,36 +6,47 @@ Parameters:
OrganizationID:
Type: String
MinLength: "1"

ADFVersion:
Type: String
MinLength: "1"

LambdaLayer:
Type: String
MinLength: "1"

CrossAccountAccessRole:
Type: String
MinLength: "1"

PipelineBucket:
Type: String
MinLength: "1"

RootAccountId:
Type: String
MinLength: "1"

CodeBuildImage:
Type: String
MinLength: "1"

CodeBuildComputeType:
Type: String
MinLength: "1"

SharedModulesBucket:
Type: String
MinLength: "1"

PipelinePrefix:
Type: String
MinLength: "1"

StackPrefix:
Type: String
MinLength: "1"

ADFLogLevel:
Type: String
MinLength: "1"
Expand Down Expand Up @@ -98,6 +109,7 @@ Resources:
Resource: !Sub "${ADFPipelineBucket.Arn}/*"
Roles:
- !Ref DeploymentMapProcessingLambdaRole

CrossAccountCloudFormationPolicy:
Type: "AWS::IAM::ManagedPolicy"
Properties:
Expand Down Expand Up @@ -178,6 +190,7 @@ Resources:
Type: "AWS::IAM::Role"
Properties:
Path: "/adf-automation/"
RoleName: "adf-pipeline-provisioner-generate-inputs"
AssumeRolePolicyDocument:
Version: "2012-10-17"
Statement:
Expand Down Expand Up @@ -206,6 +219,7 @@ Resources:
- "ssm:PutParameter"
Resource:
- "*"

StoreDefinitionLambdaRole:
Type: "AWS::IAM::Role"
Properties:
Expand All @@ -229,6 +243,7 @@ Resources:
- "s3:PutObject"
Resource:
- !Sub "${ADFDefinitionBucket.Arn}/*"

IdentifyOutOfDatePipelinesLambdaRole:
Type: "AWS::IAM::Role"
Properties:
Expand Down Expand Up @@ -537,6 +552,7 @@ Resources:
- cdk synth --app adf-build/cdk/generate_pipeline_stacks.py -vv
- python adf-build/cdk/execute_pipeline_stacks.py
ServiceRole: !GetAtt PipelineManagementCodeBuildProjectRole.Arn

PipelineManagementCodeBuildProjectRole:
Type: AWS::IAM::Role
Properties:
Expand Down
1 change: 1 addition & 0 deletions src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/global.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Resources:
- !Sub "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/adf-codebuild-role"
- !Sub "arn:${AWS::Partition}:iam::${DeploymentAccountId}:role/adf-codebuild-role"
- !Sub "arn:${AWS::Partition}:iam::${DeploymentAccountId}:role/adf-pipeline-provisioner-codebuild-role"
- !Sub "arn:${AWS::Partition}:iam::${DeploymentAccountId}:role/adf-automation/adf-pipeline-provisioner-generate-inputs"
Action:
- sts:AssumeRole
Path: /
Expand Down