Fix correct use of partitions #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** Some of the pull requests might have overlapped with the pull request that introduced support for the `aws-us-gov` partition. By searching for `:aws:`, I found a number of references that were still hard coding the `aws` partition. **What?** Adding support for dynamic partitions where it was not supported yet.
javydekoning
approved these changes
Aug 26, 2022
Contributor
javydekoning
left a comment
javydekoning
left a comment
There was a problem hiding this comment.
Thanks, looks good!
StewartW
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Some of the pull requests might have overlapped with the pull request that introduced support for the
aws-us-govpartition.By searching for
:aws:, I found a number of references that were still hard coding theawspartition.What?
Adding support for dynamic partitions where it was not supported yet.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.