Fix use of separate container image per target #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** As reported by awslabs#382, setting a specific container image to use by the CodeBuild provider to deploy to a target resulted in an error. The CDK stack would fail to synthesize as the 'custom_repo' resource name was already present in the stack. **What?** This fix ensures a unique identifier is used for custom container repositories.
javydekoning
approved these changes
Aug 26, 2022
StewartW
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #382
Why?
As reported by #382, setting a specific container image to use by the
CodeBuild provider to deploy to a target resulted in an error.
The CDK stack would fail to synthesize as the 'custom_repo' resource
name was already present in the stack.
What?
This fix ensures a unique identifier is used for custom container repositories.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.