Fix update process to only flag helpers as executable #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** Multiple files were marked as executable without a specific reason to be executable. A permission change in our repository easily goes unnoticed when a pull request is opened. **What?** With this change, we keep track of the files that should be marked executable and only flag those as such. If a file would end up in the ADF repo with the wrong permissions, this will not get replicated to the bootstrap / pipelines repository as managed in ADF user environments. This change also updates the permissions of files that were marked executable without a good reason to be executable.
StewartW
approved these changes
Aug 25, 2022
javydekoning
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Multiple files were marked as executable without a specific reason to be
executable. A permission change in our repository easily goes unnoticed when
a pull request is opened.
What?
With this change, we keep track of the files that should be marked executable
and only flag those as such. If a file would end up in the ADF repo with the
wrong permissions, this will not get replicated to the bootstrap / pipelines
repository as managed in ADF user environments.
This change also updates the permissions of files that were marked executable
without a good reason to be executable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.