Fix: Wave deployment input data #484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbkok
requested review from
StewartW and
javydekoning
and removed request for
StewartW and
javydekoning
sbkok
changed the title
sbkok
force-pushed
the
fix/wave-deployments
branch
from
19ea5a6 to
06f9a69
Compare
sbkok
changed the title
Collaborator
Author
|
Changes in this PR are moved towards the pipeline state machine PR #424. |
**Why?** When generating the waves, it does so in the input generation. When it was shared to the actual deployment of the CodePipeline stack, the data types did not match. **What?** This pull request adds comments and restructures the wave generation at the input side to make it work. Co-authored by: StewartW
sbkok
force-pushed
the
fix/wave-deployments
branch
from
06f9a69 to
87ead11
Compare
Collaborator
Author
sbkok
added a commit
to StewartW/aws-deployment-framework
that referenced
this pull request
Aug 26, 2022
sbkok
pushed a commit
that referenced
this pull request
Aug 26, 2022
) * Refactor: Pipeline Management State Machine Seperate out Pipeline Mananagement away from CodePipeline and remove the major bottlenecks of building each deployment map sequentially. Starts to isolate the CodeCOmmit repository and moves the source of deployment maps into an S3 Bucket. Sets the groundwork for future refactoring of Pipeline Management and moves towards enabling decentralised deployment maps. Authored-by: Stewart Wallace * Updating documentation * Fixing yamllint errors * final tox issues: * Update docs/technical-guide.md Co-authored-by: Simon Kok * Fixing some issues with testing * Enabling create repo based on config value * Code Review Suggestions * Copy Paste Error * removing packaged.yml and fixing trailing spaces * Missing default scm config value * Apply suggestions from code review Co-authored-by: Simon Kok * Apply suggestions from code review Co-authored-by: Simon Kok * Changing permissions of src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml * Passing thru log level param * Restricting IAM permissions to prefix * Updating Function names Adding ADF Prefix to make it clearer that they are part of the ADF ecosystem Co-authored-by: Simon Kok * Apply suggestions from code review * Code Review Suggestions * removing condition * Add wave generation test from #484 Co-authored-by: Simon Kok * Make use of Temp.Directory to fetch the deployment map files Co-authored-by: Simon Kok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When generating the waves, it does so in the input generation.
When it was shared to the actual deployment of the CodePipeline stack, the data types did not match.
What?
This pull request adds comments and restructures the wave generation at the input side to make it work.
This PR also fixes a typo and optimizes the generation of waves by using
yieldonly.Co-authored by: StewartW
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.