Fix: #474 Generated Policy Size Too Long #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbkok
requested changes
Aug 10, 2022
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Only a few trailing space issues to be fixed. Except those it looks good, thanks!
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/global.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon Kok <[email protected]>
javydekoning
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #474
Description of changes:
Broken down in the gist here
Separates out the policies for cloudformation-role in the target accounts and codepipeline role in the deployment account.
Now have policies for S3, KMS and a base policy that catches everything else.
Updated the shared IAM library to take in a list of policies to update now, also accepts single string and will treat it accordingly.
Existing update policy code also provides backward compatibility because it checks if the statement with the SID exists in the policy and if it can't find it - it does nothing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.