feat: use default description as CodeCommit repository description #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a pipeline description is given it was already propagated to the CodeCommit repository. Only the schema did not allow to provide the description, and the IAM policy contained an invalid action and did not allow description updates. Issue: awslabs#468
added 2 commits
April 8, 2022 10:40
StewartW
previously approved these changes
Apr 8, 2022
Contributor
|
@javydekoning Can you review this please |
sbkok
requested changes
Aug 12, 2022
Comment on lines
-84
to
-90
| if not _repo_exists and not _stack_exists: | ||
| LOGGER.info( | ||
| 'Ensuring State for CodeCommit Repository Stack %s on Account %s', | ||
| self.name, | ||
| self.account_id, | ||
| ) | ||
| cloudformation.create_stack() |
Collaborator
There was a problem hiding this comment.
The change here will perform updates to the CodeCommit CloudFormation stack.
Before we only created the repository, we didn't update it. I feel we should protect the code from being deleted by accident.
So we will also need an update policy to retain the repository just in case for that to be safe.
Can you add that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #468
Description of changes:
When a pipeline description is given it was already propagated to the CodeCommit repository. Only the schema did not allow to provide the description, and the IAM policy contained an invalid action and did not allow description updates.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.