feat: encrypt sns topic using the ADF CMK KMS Key #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 13, 2022 15:48
Because ADF already has a KMS key that is used for encryption. It makes sense to use that key for the SNS notifications as well. Issue: awslabs#422
StewartW
previously approved these changes
Jan 17, 2022
Contributor
StewartW
left a comment
StewartW
left a comment
There was a problem hiding this comment.
Makes sense.
Might be good to make it configurable going forward but I'm happy with that as is.
sbkok
requested changes
Feb 1, 2022
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
Outdated
Show resolved
Hide resolved
…otstrap/deployment/global.yml Co-authored-by: Simon Kok <[email protected]>
Contributor
Author
|
Ah that makes sense! I applied your suggestion. |
StewartW
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #422
Description of changes:
Because ADF already has a KMS key that is used for encryption. It makes sense to use that key for the SNS notifications as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.