Change example email domains and account ids #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** To ensure that email addresses or account ids are not exposed by accident, this is the first step to ensure that the same example email addresses and account ids are used. Such that a mechanism can be introduced to prevent accidentally committing email addresses or account ids that are not supposed to be share publicly. **What?** This step updates all the email addresses and account ids in the code and documentation. The instructions for our contributors received an update too. In case you want to specify an example email address, please make use of one of the following email addresses: * `[email protected]` * `[email protected]` * `[email protected]` * Or another `@example.com` * For tests that could potentially create accounts (if mocks failed to work), please use `[email protected]` instead. When you want to write documentation/tests and need an example account id, the following account ids may be used: * `111111111111` * `222222222222` * ... to ... * `999999999999` * or to show the length more easily: * `012345678910` * `012345671234` * `123456789012`
sbkok
commented
Dec 24, 2021
...ase/initial_commit/bootstrap_repository/adf-build/shared/tests/stubs/stub_deployment_map.yml
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/example-adfconfig.yml
Show resolved
Hide resolved
thomasmcgannon
previously approved these changes
Jan 7, 2022
Collaborator
thomasmcgannon
left a comment
thomasmcgannon
left a comment
There was a problem hiding this comment.
Lots of dedication to cleaning up :D lgtm!
StewartW
approved these changes
Jan 7, 2022
thomasmcgannon
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
To ensure that email addresses or account ids are not exposed by accident,
this is the first step to ensure that the same example email addresses
and account ids are used. Such that a mechanism can be introduced to
prevent accidentally committing email addresses or account ids that are
not supposed to be share publicly.
What?
This step updates all the email addresses and account ids in the code and
documentation.
The instructions for our contributors received an update too.
In case you want to specify an example email address, please make use of
one of the following email addresses:
[email protected][email protected][email protected]@example.complease use
[email protected]instead.When you want to write documentation/tests and need an example account id, the
following account ids may be used:
111111111111222222222222999999999999012345678910012345671234123456789012By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.